Hello Sebastien, Could you please release 9.0.0-M2? I'm planning to perform release of Apache OpenMeetings in 2-3 weeks, so I need to eliminate all SNAPSHOT dependencies :)
On Sun, 21 Apr 2019 at 19:56, Maxim Solodovnik <[email protected]> wrote: > > Thanks a million for the changes! > > On Sun, 21 Apr 2019 at 16:02, Sebastien Briquet <[email protected]> wrote: > > > > > @Martin: thank you very much for your commits! > > > > Except for the java 11 javadoc-url related commit, I think it is safe to > > > > cherry-pick other commits to wicket8.x, right? > > > > > > > > > Yes. I think so too. > > > > > > (I'm actually wondering > > > > about the wicket:header-items one) > > > > > > > > > > This one as well. > > > > > > > Done, all applied. > > wicket8.x and wicket9.x snapshots deployed. > > > > > > > You can check by starting the samples in wicket8.x branch and checking the > > > browser's dev tools console. > > > > > > > I will check this... > > > > > > > > > > > > > > About Unit Tests, yes you are right there is no tests! :) The idea was - > > > > because spare time is limited of course - to test all features by a > > > > demo. > > > > This way users have a demo for each feature which is useful and if there > > > is > > > > an issue, they can report through a github issue. I think it is more > > > > efficient than spending a large amount of time trying to test everything > > > in > > > > a UI framework where the layout is also very important, and very > > > difficult > > > > to test... > > > > > > > > > > Amazing job! :-) > > > This way you had time to provide all these demos! > > > > > > > > Thank you !! :)) > > > > > > > > > > > I fixed the "javadoc is missing" issue I had on my side (somehow my JDK > > > did > > > > not contain the javadoc program. I apt install it again, as well as > > > > openjdk-11-jdk-headless package just to be sure, and it works) > > > > > > > > I also enabled TravisCI job for wicket9.x so snapshots will (should) be > > > > deployed on successful builds from now. > > > > https://travis-ci.org/sebfz1/wicket-jquery-ui/branches > > > > > > > > @Maxim: I merged the MR in wicket8.x and applied the change in > > > > wicket9.x. > > > > But it seems that Travis does not deploy wicket8.x branch... :( > > > > > > > Somehow Travis is deploying wicket8.x again, not sure I fixed something.... > > > > -- > WBR > Maxim aka solomax -- WBR Maxim aka solomax
