andruhon commented on a change in pull request #382: WICKET-6688 add RFC and
replace eval with DOM eval
URL: https://github.com/apache/wicket/pull/382#discussion_r327370595
##########
File path:
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
##########
@@ -956,7 +975,7 @@
try {
// do the evaluation in global
scope
- var f = window.eval(toExecute);
+ var f =
jQuery.globalEval(toExecute, {nonce: nonce});
Review comment:
@martin-g I don't really want to promote some dodgy non-streamline solution.
These are just examples of possible solutions for the problem:
https://github.com/andruhon/wicket-delayed-animation/tree/primitive-timeout-solution
https://github.com/andruhon/wicket-delayed-animation/tree/primitive-pubsub-solution
It has no wicket java, only wicket-ajax-jquery and a fake response in
response.xml
Anyway I believe the solution should be javascripty, rather than something
that has to be parsed. Maybe something like Wicket.Channel.pause() and
Wicket.Channel.resume() if say we want to pause all ajax during this animation,
or maybe some other methods *to be called from JS* to pause and notify
particular request.
I'll think a little bit more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
