andruhon commented on a change in pull request #382: WICKET-6688 add RFC and
replace eval with DOM eval
URL: https://github.com/apache/wicket/pull/382#discussion_r328396982
##########
File path:
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
##########
@@ -956,7 +975,7 @@
try {
// do the evaluation in global
scope
- var f = window.eval(toExecute);
+ var f =
jQuery.globalEval(toExecute, {nonce: nonce});
Review comment:
@svenmeier I like idea. The one thing I don't understand why the count is
needed? As far as I know it's either waiting or proceeding, so I think it won't
get to the request (with a suspend) unless It's not suspended.
@svenmeier, @martin-g please have a look at this implementation:
https://github.com/andruhon/wicket-delayed-animation/commit/e799a1dfbd24fd35e0701d452c95cbf51f732186
Here I simply disallow to call suspend when evaluation is not happening,
also it doesn't allow to call suspend twice, so I think boolean in this case is
enough.
I added two buttons with slow 2.5s suspended fade out, you can try quickly
clicking them both.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
