andruhon commented on a change in pull request #409: [WICKET-6750] allow to 
abort currently executing AJAX request 
URL: https://github.com/apache/wicket/pull/409#discussion_r384249859
 
 

 ##########
 File path: 
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
 ##########
 @@ -547,13 +576,29 @@
                 */
                ajax: function (attrs) {
                        this._initializeDefaults(attrs);
-
                        var res = Wicket.channelManager.schedule(attrs.ch, 
Wicket.bind(function () {
                                this.doAjax(attrs);
                        }, this));
                        return res !== null ? res: true;
                },
 
+               /**
+                * Aborts current AJAX request, if any is running, for default 
channel.
+                * WARNING! Mind that this does not implies and server 
immediately will know about
 
 Review comment:
   I'd reword it somewhat like this:
   ```
   Abort AJAX request if one in default channel is currently running.
   
   WARNING! Mind that calling this method does not imply that the server will 
immediately know about the request being aborted.
   Server side processing and page are likely to continue.
   This method could be useful to cancel huge AJAX requests such as file 
uploads.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to