[GitHub] [wicket] reiern70 commented on a change in pull request #409: [WICKET-6750] allow to abort currently executing AJAX request

[GitBox]

reiern70 commented on a change in pull request #409: [WICKET-6750] allow to 
abort currently executing AJAX request 
URL: https://github.com/apache/wicket/pull/409#discussion_r384385873
 
 

 ##########
 File path: 
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
 ##########
 @@ -547,13 +576,29 @@
                 */
                ajax: function (attrs) {
                        this._initializeDefaults(attrs);
-
                        var res = Wicket.channelManager.schedule(attrs.ch, 
Wicket.bind(function () {
                                this.doAjax(attrs);
                        }, this));
                        return res !== null ? res: true;
                },
 
+               /**
+                * Aborts current AJAX request, if any is running, for default 
channel.
+                * WARNING! Mind that this does not implies and server 
immediately will know about
 
 Review comment:
   @andruhon thanks for your comment.
   
   
![image](https://user-images.githubusercontent.com/462655/75333553-fce9c300-588e-11ea-9fb1-c97e53a7b5b3.png)
   
   I have reworded it like above. Hope is is more clear now.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services