theigl commented on a change in pull request #417: WICKET-6761 Multiple
websocket connections from the same session
URL: https://github.com/apache/wicket/pull/417#discussion_r396380385
##########
File path:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/BaseWebSocketBehavior.java
##########
@@ -93,10 +119,12 @@ public void renderHead(Component component,
IHeaderResponse response)
int pageId = component.getPage().getPageId();
variables.put("pageId", pageId);
variables.put("resourceName", "");
+ variables.put("resourceToken", "");
Review comment:
Ah ok. I have been using wicket with "pretty" URLs without any `pageId`
parameters for so long that I forgot how it works out of the box.
If we want to use it for pages as well, we definitely need a better name for
the parameter. What do you think about `connectionId` or `connectionToken`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
