martin-g commented on a change in pull request #417: WICKET-6761 Multiple
websocket connections from the same session
URL: https://github.com/apache/wicket/pull/417#discussion_r396389423
##########
File path:
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/BaseWebSocketBehavior.java
##########
@@ -93,10 +119,12 @@ public void renderHead(Component component,
IHeaderResponse response)
int pageId = component.getPage().getPageId();
variables.put("pageId", pageId);
variables.put("resourceName", "");
+ variables.put("resourceToken", "");
Review comment:
`connectionToken` sounds better.
But who is creating this token ? I didn't see anything about this in your PR.
Have you tested your PR? Does it really solve your issue ? Because due to
the typo in the Javascript code I have the feeling you didn't actually used
this code.
Please add changes to the Wicket Examples demo application that makes it
easier for me to play with this new functionality.
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
