martin-g commented on a change in pull request #436:
URL: https://github.com/apache/wicket/pull/436#discussion_r433114761
##########
File path:
wicket-util/src/main/java/org/apache/wicket/util/encoding/UrlEncoder.java
##########
@@ -16,58 +16,140 @@
*/
package org.apache.wicket.util.encoding;
-import java.io.CharArrayWriter;
+import java.io.ByteArrayOutputStream;
import java.io.UnsupportedEncodingException;
import java.nio.charset.Charset;
import java.nio.charset.IllegalCharsetNameException;
import java.nio.charset.UnsupportedCharsetException;
-import java.util.BitSet;
import org.apache.wicket.util.lang.Args;
/**
- * Adapted from java.net.URLEncoder, but defines instances for query string
encoding versus URL path
+ * Adapted from Spring's UriUtils, but defines instances for query string
encoding versus URL path
Review comment:
Same as above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
