martin-g commented on a change in pull request #436:
URL: https://github.com/apache/wicket/pull/436#discussion_r433114445
##########
File path:
wicket-util/src/main/java/org/apache/wicket/util/encoding/UrlDecoder.java
##########
@@ -16,25 +16,25 @@
*/
package org.apache.wicket.util.encoding;
+import java.io.ByteArrayOutputStream;
import java.io.UnsupportedEncodingException;
import java.nio.charset.Charset;
import java.nio.charset.IllegalCharsetNameException;
import java.nio.charset.UnsupportedCharsetException;
import org.apache.wicket.util.lang.Args;
-import org.apache.wicket.util.string.Strings;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/**
- * Adapted from java.net.URLDecoder, but defines instances for query string
decoding versus URL path
+ * Adapted from Spring's UriUtils, but defines instances for query string
decoding versus URL path
* component decoding.
* <p/>
* The difference is important because a space is encoded as a + in a query
string, but this is a
* valid value in a path component (and is therefore not decode back to a
space).
- *
- * @author Doug Donohoe
- * @see java.net.URLDecoder
+ *
+ * @author Thomas Heigl
+ * @see org.springframework.web.util.UriUtils
Review comment:
I think this breaks the Javadoc build because wicket-util does not
depend on spring-web.
Please the first line of the javadoc with something like "Adapted from
Spring Framework's UrilUtils class"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
