This would be great for OSGi too =) Perhaps move the class that import junit.* to a wicket-junit5 maven module?
Thanks, Matt Pavlovich > On Feb 22, 2023, at 2:11 AM, Martin Grigorov <mgrigo...@apache.org> wrote: > > BTW there is a ticket from Apache Causeway team requesting to extract > WicketTester in its own Maven module because currently it causes problems > when trying to use wicket-core as a Java module. > > https://issues.apache.org/jira/browse/WICKET-7019 > > But maybe it could be done for M2 > > On Thu, Feb 9, 2023 at 1:10 PM Maxim Solodovnik <solomax...@gmail.com> > wrote: > >> from mobile (sorry for typos ;) >> >> >> On Thu, Feb 9, 2023, 18:03 Andrea Del Bene <an.delb...@gmail.com> wrote: >> >>> Excuse my silly question but isn't ok for milestone version to depend on >> a >>> snapshot version (fileupload 2.0-SNAPSHOT)? >>> >> >> Unfortunately not :( >> The build will not be reproducible >> >> >> >>> On Thu, Feb 9, 2023 at 8:36 AM Emond Papegaaij < >> emond.papega...@gmail.com> >>> wrote: >>> >>>> Op do 9 feb. 2023 om 08:32 schreef Martin Grigorov < >> mgrigo...@apache.org >>>> : >>>> >>>>> On Thu, Feb 9, 2023 at 9:16 AM Emond Papegaaij < >>>> emond.papega...@gmail.com> >>>>> wrote: >>>>> >>>>>> Op do 9 feb. 2023 om 07:47 schreef Martin Grigorov < >>>> mgrigo...@apache.org >>>>>> : >>>>>> >>>>>>> Please update >>>>>>> >>>>>> >>>>> >>>> >>> >> https://cwiki.apache.org/confluence/display/WICKET/Migration+to+Wicket+10.0 >>>>>>> that the Component Queueing is gone >>>>>>> >>>>>>> Before releasing M1 I think we need to: >>>>>>> 1) update all dependencies to their latest stable version >>>>>>> 2) copy over commons-fileupload2 classes to wicket-util or a new >>>> Maven >>>>>>> module >>>>>>> >>>>>> >>>>>> What about shading the classes in an internal package? I'm a bit >>>>> concerned >>>>>> with having to cope with different classes with the same fqcn when >>> some >>>>>> other dependency also pulls in commons-fileupload. >>>>>> >>>>> >>>>> I am not sure whether Maven would be happy to use a -SNAPSHOT for the >>>>> shading process when making a release. If you mean >> maven-shade-plugin. >>>>> Doing it manually should work! >>>>> >>>> >>>> Yes, releasing against a SNAPSHOT version is not a very good idea, even >>> if >>>> shaded. That will give issues trying to rebuild a certain version if >>>> something has changed. Copy-pasting and changing the package should be >>> ok. >>>> >>>> Best regards, >>>> Emond >>>> >>> >>> >>> -- >>> Andrea Del Bene. >>> Apache Wicket committer. >>> >>
