Good catch. Looking at the history, it has always been there from the moment we moved from the old clirr plugin to japicmp. It seems to even predate wicket 10 and 10.x builds fine without it. We should remove it on 10.x and master.
Emond Op do 3 sep 2026 om 08:52 schreef Maxim Solodovnik <[email protected]>: > OK, jackson will not be updated :) > > on the other have we have following code for japicmp in our pom: > ``` > <excludes> > <exclude> > <!-- [ERROR] Failed to execute goal > com.github.siom79.japicmp:japicmp-maven-plugin:0.15.3:cmp (default) on > project wicket-core: There is at least one incompatibility: > > org.apache.wicket.markup.html.form.EnumChoiceRenderer:METHOD_REMOVED_IN_SUPERCLASS > --> > org.apache.wicket.markup.html.form.EnumChoiceRenderer > </exclude> > </excludes> > ``` > > On Thu, 3 Sept 2026 at 13:46, Emond Papegaaij <[email protected]> > wrote: > > > > Hi Maxim, > > > > Those are not compatible, so japicmd is right to complain. This is one of > > the reasons why I would like to release major versions more often. The > > Wicket API has no clear SPI vs API boundary, so we count everything as > > public API. Unfortunately, this also means we cannot change types like > this > > on 10 and below. JsonRequestLogger has a protected getMapper method that > > returns this type, so it is part of our API. > > > > Emond > > > > Op do 3 sep 2026 om 04:46 schreef Maxim Solodovnik <[email protected] > >: > > > > > Hello All, > > > > > > Is there any way to tell `japicmp-maven-plugin` > > > com.fasterxml.jackson.databind.ObjectMapper -> > > > tools.jackson.databind.ObjectMapper change is OK? :) > > > Or Jackson update should remain in 11.x only? :) > > > > > > On Wed, 2 Sept 2026 at 18:30, Maxim Solodovnik <[email protected]> > > > wrote: > > > > > > > > Hello All, > > > > > > > > from mobile (sorry for typos ;) > > > > > > > > > > > > On Wed, Sep 2, 2026, 13:26 Maxim Solodovnik <[email protected]> > > > wrote: > > > >> > > > >> I have prepared https://github.com/apache/wicket/pull/1564 :) > > > >> > > > >> Please let me know if similar changes (in EE10 mode) would be OK for > > > >> wicket-10.x :) > > > > > > > > > > > > Can someone review this PR please? :) > > > > > > > >> > > > >> On Wed, 2 Sept 2026 at 13:05, Pedro Santos <[email protected]> > wrote: > > > >> > > > > >> > Hi Maxim, > > > >> > > > > >> > > wicket-10 has CDI 3.0 and weld 4.0 is it on purpose? :) > > > >> > > > > >> > I think it's a less used module that missed the version bump in > the > > > branch, > > > >> > not on purpose. > > > >> > > > > >> > > but CDI/Weld is 4.1/6.0 which is EE11 :) > > > >> > > > > >> > Here I assumed that we would rather have the last version in > master. > > > >> > > > > >> > Pedro Santos > > > >> > > > > >> > > > > >> > Em qua., 2 de set. de 2026 às 02:50, Maxim Solodovnik < > > > [email protected]> > > > >> > escreveu: > > > >> > > > > >> > > Similar question regarding wicket-11 > > > >> > > > > > >> > > servlet spec is 6.0.0 which is EE10 > > > >> > > but CDI/Weld is 4.1/6.0 which is EE11 :) > > > >> > > > > > >> > > On Wed, 2 Sept 2026 at 12:23, Maxim Solodovnik < > > > [email protected]> > > > >> > > wrote: > > > >> > > > > > > >> > > > Hello All, > > > >> > > > > > > >> > > > Due to Wicket 10 is based at servlets 6.0 I'm assuming it > should > > > be > > > >> > > > EE10 compatible > > > >> > > > BUT according to https://jakarta.ee/release/10/ EE10 must > have > > > CDI 4.0 > > > >> > > > > > > >> > > > wicket-10 has CDI 3.0 and weld 4.0 is it on purpose? :) > > > >> > > > > > > >> > > > The question arise due to I have updated `wicketstuff-10` to > jetty > > > >> > > > 12.1 > > > >> > > > > > > https://github.com/wicketstuff/core/commit/e29e13abced816beaed2cc76cdb7d5d2e64db8dc > > > >> > > > > > > >> > > > And observing Weld/CDI issues while trying to prepare similar > PR > > > for > > > >> > > wicket > > > >> > > > > > > >> > > > -- > > > >> > > > Best regards, > > > >> > > > Maxim > > > >> > > > > > >> > > > > > >> > > > > > >> > > -- > > > >> > > Best regards, > > > >> > > Maxim > > > >> > > > > > >> > > > >> > > > >> > > > >> -- > > > >> Best regards, > > > >> Maxim > > > > > > > > > > > > -- > > > Best regards, > > > Maxim > > > > > > > -- > Best regards, > Maxim >
