reiern70 opened a new issue, #1639:
URL: https://github.com/apache/wicket/issues/1639
#1638 adds color themes shared by the components of wicket-extensions: CSS
custom properties named --wicket-theme-*, set by a theme class, and a
ThemeBehavior that applies a theme to a page or a component. The
DynamicDataTable, the ProgressBar and the CollapsiblePanel read their colors
from them.
The other components of wicket-extensions keep their own hard-coded colors,
so a themed page still shows them in their old look. This issue is about making
them read the theme properties as well:
- ModalDialog: its DefaultTheme (ajax/markup/html/modal/theme/theme.css)
styles the dialog, the overlay and the title bar.
- DataTable and its toolbars (headers, navigation, no-records toolbar,
export toolbar), so a DataTable and a DynamicDataTable on the same page look
alike.
- Palette (markup/html/form/palette/theme/palette.css).
- The tree themes (markup/html/repeater/tree/theme/windows and human).
- AutoCompleteTextField (DefaultCssAutoCompleteTextField.css).
- UploadProgressBar (UploadProgressBar.css), which could reuse the look of
the ProgressBar.
- RatingPanel (RatingPanel.css).
- TabbedPanel, Wizard and BreadCrumbBar, which rely on the application's
CSS today.
Goals, as for the components already themed:
- Read the properties only inside a theme, so an application that does not
use a theme sees no change.
- Switch by CSS class only, with no inline style, so the components keep
working under a strict Content Security Policy.
- Add properties to the theme only where the existing ones cannot express
what a component needs, and document them in wicket-theme.css.
The components can be done one at a time, each in its own pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
