reiern70 opened a new issue, #1640: URL: https://github.com/apache/wicket/issues/1640
The script that sets up the web socket connection, `wicket-websocket-setup.js.tmpl` in wicket-native-websocket-core, still calls `jQuery.extend(Wicket.WebSocket, ...)` to store the page id, the context, the connection token and the other settings. Master's JavaScript no longer needs jQuery. On a page that does not load jQuery, a page with a `WebSocketBehavior` fails with `ReferenceError: jQuery is not defined`, the connection is never opened and no push message reaches the page. The examples show it when started with `-Dwicket.examples.use=VANILLA`. Proposed fix: use `Object.assign` instead of `jQuery.extend`, which behaves the same for this flat object, and add a test that the rendered setup script does not refer to jQuery. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
