dashorst commented on issue #1867: URL: https://github.com/apache/wicket/issues/1867#issuecomment-6721264591
Implemented in #1871 (master), #1872 (wicket-11.x) and #1873 (wicket-10.x). The profile is `codestyle/wicket-formatter.xml`, run by Spotless 3.10.4 with Eclipse JDT 4.41 on all three lines. Starting from the old `org.eclipse.jdt.core.prefs` unchanged, applying it would have touched 1804 of 3402 Java files. With comment formatting off, hand-made line breaks kept, the missing newer settings matched to the code, and the line length raised from 100 to 120 columns, the reformat on master touches 1197 files (+12.5k/−10.5k lines), whitespace only: | Change | Lines | Files | |---|---|---| | Brace moved to its own line | 9.7k | 452 | | Space indentation replaced by tabs | 4.1k | 365 | | Whitespace removed from empty lines | 2.9k | 397 | | Line over 120 columns wrapped | 1.9k | 251 | The maintenance lines are reformatted with the same profile and formatter version, so code that is identical across lines stays identical and cherry-picks keep applying cleanly. Still open: what happens to `wicket-eclipse-settings`, CRLF normalization (187 Java files, no `.gitattributes`), and formatting beyond Java (imports, poms, JavaScript). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
