dashorst opened a new issue, #1897: URL: https://github.com/apache/wicket/issues/1897
Targets **master, wicket-11.x and wicket-10.x**. The affected files are the same on all three lines; on wicket-10.x only the archetype's `pom.xml` and `Start.java` differ. The quickstart archetype and the examples load fonts and stylesheets from third-party CDNs, and the quickstart still has the look and content it got around Wicket 1.5. Every project generated from the quickstart calls Google on its first page, and its CSP is opened to two Google hosts to allow it. This follows up on #1846: nothing is distributed, so there is no release problem, but the links are worth reconsidering on their own. The fonts of the examples themselves stay with #1846. ## CDN links | What | Where | Loaded from | |---|---|---| | Yanone Kaffeesatz | quickstart `HomePage.html`; `WicketApplication.init()` adds `https://fonts.googleapis.com/css` to `style-src` and `https://fonts.gstatic.com` to `font-src` | Google Fonts | | Font Awesome 4.3.0 | `WicketExamplePage.html` and `customresourceloading/CustomLoadedTemplate.html`; `WicketExampleApplication` and `authentication3/MyAuthenticatedWebApplication` add it to the CSP | maxcdn.bootstrapcdn.com | | Yanone Kaffeesatz | 14 test pages in wicket-core-tests, over `http://`, one of them `PageWithScriptTemplate_expected.html` | Google Fonts | | jQuery 1.4.2 | `ResouceBundleTest` and `BundlesPage_ext_result.html` in wicket-core-tests | ajax.googleapis.com | - **Google Fonts** sends every visitor's IP address to Google. The Landgericht München I held that embedding them that way violates the GDPR (20 January 2022, 3 O 17493/20). A starter project should not make that choice for its users, and whoever copies the quickstart's CSP learns to allow-list Google. - **Font Awesome** is not used anywhere in wicket-examples: no `fa` classes, no `FontAwesome` font-family. The links and the two CSP entries can go without a replacement. Font Awesome 4 has been end-of-life for years. - **The core tests** fetch nothing: WicketTester never loads the stylesheet, so the links are inert text. They can go, together with the matching line in `PageWithScriptTemplate_expected.html`. The jQuery URL in `ResouceBundleTest` is what that test is about, an external resource in a bundle, and stays. ## The quickstart's look and content The page is a fixed 650px box positioned absolutely between a navy header and a blue footer, with Yanone Kaffeesatz headings, Georgia text at 13pt and a 50px `logo.png`. It has no layout for phones. Its content is out of date: - It sends people to IRC on freenode. The community page lists the mailing lists and the #wicket channel on the ASF Slack. - `wicket-users.markmail.org` no longer resolves. - Bugs go "to a JIRA issue" as "a patch". Since 2026 the project uses GitHub Issues and pull requests, and the JIRA link now asks for a login. - `help/email.html` only works through a redirect to `/community/#lists`. - The placeholder version in the markup is `1.5-SNAPSHOT`. The `version` label replaces it at runtime, but it is what people read in the source. ## Options for the styling The site and the reference guide share a design now. The quickstart could follow it without any third-party request: 1. **System fonts only.** Use the fallback stacks of the site (apache/wicket-site#27): an old-style serif (Iowan Old Style, Palatino Linotype, Palatino, URW Palladio L, P052, Georgia) and a humanist sans (Seravek, Gill Sans Nova, Ubuntu, Calibri). This needs no dependency and no font files. The page looks close to the site, but not the same. 2. **The site's fonts from webjars.** The generated `pom.xml` depends on `org.webjars.npm:fontsource__alegreya`, `-alegreya-sans`, `-alegreya-sc` and `-jetbrains-mono` (5.3.0), and `style.css` loads them from `webjars/fontsource__alegreya/5.3.0/files/…`. The servlet container serves `META-INF/resources` from the jars in `WEB-INF/lib`, and WicketFilter passes those requests on, as it does for `style.css` today. The archetype holds no font files, so this raises no Category B question. The cost is four extra dependencies in every generated project, which is also the starting point for bug reproducers, and a font version in the CSS paths. Either way the CSP in `WicketApplication.init()` keeps only `'self'` for `style-src`, and `logo.png` could become the SVG mark the site uses. ## To decide - System fonts or the site's fonts from webjars for the quickstart. - Whether the quickstart takes the site's whole design (colours, ribbon, dark mode) or only its typography. - Whether the quickstart's content keeps the "reporting a bug" steps, now pointing at GitHub Issues and the community page. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
