[ 
https://issues.apache.org/jira/browse/AXIOM-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190632#comment-13190632
 ] 

Andreas Veithen commented on AXIOM-410:
---------------------------------------

I think that "Do nothing" isn't a correct implementation for setPrefix either...
                
> Exception when called setPrefix method of ElementImpl in axiom-dom
> ------------------------------------------------------------------
>
>                 Key: AXIOM-410
>                 URL: https://issues.apache.org/jira/browse/AXIOM-410
>             Project: Axiom
>          Issue Type: Bug
>          Components: DOOM
>    Affects Versions: 1.2.13
>         Environment: Ubuntu, jdk1.6.0_23
>            Reporter: Amila Jayasekara
>              Labels: rampart, security
>         Attachments: setprefix.diff
>
>
> In axiom-dom NodeImpl's [1] "setPrefix" method is implemented as follows,
> public void setPrefix(String prefix) throws DOMException {
>        throw new DOMException(DOMException.NAMESPACE_ERR, DOMMessageFormatter
>                .formatMessage(DOMMessageFormatter.DOM_DOMAIN,
> DOMException.NAMESPACE_ERR,
>                               null));
>    }
> According to current trunk the "setPrefix" method is not overridden at
> any child class. But this method is called from opensaml framework
> when document builder is set to axiom-dom one. Above method is called for 
> Element (ElementImpl). Thus it throws DOMException. 
> I am not sure why we should throw an Exception for Element. I override method 
> with an empty body and according to my tests it works fine. (I have attached 
> the patch).
> Please review the patch and apply. 
> Thanks
> AmilaJ

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to