[
https://issues.apache.org/jira/browse/AXIOM-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190730#comment-13190730
]
Hudson commented on AXIOM-410:
------------------------------
Integrated in ws-axiom-trunk #789 (See
[https://builds.apache.org/job/ws-axiom-trunk/789/])
AXIOM-410: Correctly implement Node#setPrefix for Element and Attr nodes.
veithen :
Files :
*
/webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/DOMTestSuiteBuilder.java
*
/webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/attr
*
/webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/attr/TestSetPrefixNotNullWithNamespace.java
*
/webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/attr/TestSetPrefixNotNullWithoutNamespace.java
*
/webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestSetPrefixNotNullWithNamespace.java
*
/webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestSetPrefixNotNullWithoutNamespace.java
*
/webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/element/TestSetPrefixNull.java
*
/webservices/commons/trunk/modules/axiom/modules/axiom-dom-testsuite/src/main/java/org/apache/axiom/ts/dom/text/TestSetPrefix.java
*
/webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/AttrImpl.java
*
/webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/ElementImpl.java
*
/webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/NamedNode.java
*
/webservices/commons/trunk/modules/axiom/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/NamedNodeHelper.java
> Exception when called setPrefix method of ElementImpl in axiom-dom
> ------------------------------------------------------------------
>
> Key: AXIOM-410
> URL: https://issues.apache.org/jira/browse/AXIOM-410
> Project: Axiom
> Issue Type: Bug
> Components: DOOM
> Affects Versions: 1.2.12
> Environment: Ubuntu, jdk1.6.0_23
> Reporter: Amila Jayasekara
> Assignee: Andreas Veithen
> Labels: rampart, security
> Attachments: setprefix.diff
>
>
> In axiom-dom NodeImpl's [1] "setPrefix" method is implemented as follows,
> public void setPrefix(String prefix) throws DOMException {
> throw new DOMException(DOMException.NAMESPACE_ERR, DOMMessageFormatter
> .formatMessage(DOMMessageFormatter.DOM_DOMAIN,
> DOMException.NAMESPACE_ERR,
> null));
> }
> According to current trunk the "setPrefix" method is not overridden at
> any child class. But this method is called from opensaml framework
> when document builder is set to axiom-dom one. Above method is called for
> Element (ElementImpl). Thus it throws DOMException.
> I am not sure why we should throw an Exception for Element. I override method
> with an empty body and according to my tests it works fine. (I have attached
> the patch).
> Please review the patch and apply.
> Thanks
> AmilaJ
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
