Hi,
The summary of the notes taken is given below.
Remove the redundant params in AARServiceUploadTest
ARTIFACT_DEPLOYMENT_STATUS and ARTIFACT_CLEANER_STATUS
Removing the space between the method comment and the method
> Avoid creating objects
>> singleton for ArtifactManager, if possible.
> Use log.error(msg, e) instead of log.error(msg + e.getMessage());
Styles -
> indentation
> improving readability
ScenarioConfigurationParser
- Singleton - make the constructor private.
Final.
- Return the exception
- for configuration file not found.
In testConfig.xml, define <product> inside <products>
> first checking, log.isDebugEnabled() before log.debug()
> remove the redundant info levle log.
Single deployment method to eliminate the switch case - ArtifactDeployer
"default" (package private) instead of "protected" for deployArtifact().
Thank you.
Regards,
Pradeeban.
On Wed, Apr 18, 2012 at 4:53 PM, Krishantha Samaraweera <[email protected]
> wrote:
> more details
> »<https://www.google.com/calendar/event?action=VIEW&eid=bTA3M3I3dDJoazl1NmtqdHNmZmJvaDZvajAgZGV2QHdzbzIub3Jn&tok=MTkja3Jpc2hhbnRoYUB3c28yLmNvbWYyN2E1YjE4Mjg4YWYzYjc2ZDlhYzk4ZDU5Mjk2MmFlNGU3NTQ4YmU&ctz=Asia/Colombo&hl=en>
> Code review - System test framework
> Details:
> Project being reviewed: System Test Framework (Clarity) - Artifact
> Deployer classes.
> Link to crucible project: Will be posted once Crucible administrator
> finish ongoing configuration work.
> *When*
> Thu Apr 19 2:30pm – 3:30pm Colombo
> *Where*
> LK #59 2nd Floor Room
> (map<http://maps.google.lk/maps?q=LK+%2359+2nd+Floor+Room&hl=en>
> )
> *Calendar*
> [email protected]
> *Who*
> •
> [email protected] - organizer
> •
> Chamara Silva
> •
> Dharshana Warusavitharana
> •
> [email protected]
> •
> Nuwan Wimalasekara
> •
> Dimuthu Leelarathne
>
> Going?
> ***Yes<https://www.google.com/calendar/event?action=RESPOND&eid=bTA3M3I3dDJoazl1NmtqdHNmZmJvaDZvajAgZGV2QHdzbzIub3Jn&rst=1&tok=MTkja3Jpc2hhbnRoYUB3c28yLmNvbWYyN2E1YjE4Mjg4YWYzYjc2ZDlhYzk4ZDU5Mjk2MmFlNGU3NTQ4YmU&ctz=Asia/Colombo&hl=en>-
> Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=bTA3M3I3dDJoazl1NmtqdHNmZmJvaDZvajAgZGV2QHdzbzIub3Jn&rst=3&tok=MTkja3Jpc2hhbnRoYUB3c28yLmNvbWYyN2E1YjE4Mjg4YWYzYjc2ZDlhYzk4ZDU5Mjk2MmFlNGU3NTQ4YmU&ctz=Asia/Colombo&hl=en>-
> No<https://www.google.com/calendar/event?action=RESPOND&eid=bTA3M3I3dDJoazl1NmtqdHNmZmJvaDZvajAgZGV2QHdzbzIub3Jn&rst=2&tok=MTkja3Jpc2hhbnRoYUB3c28yLmNvbWYyN2E1YjE4Mjg4YWYzYjc2ZDlhYzk4ZDU5Mjk2MmFlNGU3NTQ4YmU&ctz=Asia/Colombo&hl=en>
> * **more options
> »<https://www.google.com/calendar/event?action=VIEW&eid=bTA3M3I3dDJoazl1NmtqdHNmZmJvaDZvajAgZGV2QHdzbzIub3Jn&tok=MTkja3Jpc2hhbnRoYUB3c28yLmNvbWYyN2E1YjE4Mjg4YWYzYjc2ZDlhYzk4ZDU5Mjk2MmFlNGU3NTQ4YmU&ctz=Asia/Colombo&hl=en>
>
> Invitation from Google Calendar <https://www.google.com/calendar/>
>
> You are receiving this courtesy email at the account [email protected] because
> you are an attendee of this event.
>
> To stop receiving future notifications for this event, decline this event.
> Alternatively you can sign up for a Google account at
> https://www.google.com/calendar/ and control your notification settings
> for your entire calendar.
>
> _______________________________________________
> Dev mailing list
> [email protected]
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>
--
Kathiravelu Pradeeban.
Software Engineer.
Cloud Technologies Team.
WSO2 Inc.
Blog: [Llovizna] http://kkpradeeban.blogspot.com/
M: +94 776 477 976
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev
