Please find the status of each code review pointers below. On Thu, Apr 19, 2012 at 3:42 PM, Kathiravelu Pradeeban <[email protected]>wrote:
> Hi, > The summary of the notes taken is given below. > > Remove the redundant params in AARServiceUploadTest > ARTIFACT_DEPLOYMENT_STATUS and ARTIFACT_CLEANER_STATUS > Done > > Removing the space between the method comment and the method > Done > > > Avoid creating objects > >> singleton for ArtifactManager, if possible. > Done > > > Use log.error(msg, e) instead of log.error(msg + e.getMessage()); > Done > > Styles - > > indentation > > improving readability > Done > > ScenarioConfigurationParser > - Singleton - make the constructor private. > Final. > - Return the exception > - for configuration file not found. > Done. > > In testConfig.xml, define <product> inside <products> > Done > > > first checking, log.isDebugEnabled() before log.debug() > > remove the redundant info levle log. > Done > > Single deployment method to eliminate the switch case - ArtifactDeployer > We discussed this but not agreed to fix. > > "default" (package private) instead of "protected" for deployArtifact(). > Done Thanks, Krishantha. > Thank you. > Regards, > Pradeeban. > > On Wed, Apr 18, 2012 at 4:53 PM, Krishantha Samaraweera < > [email protected]> wrote: > >> more details >> »<https://www.google.com/calendar/event?action=VIEW&eid=bTA3M3I3dDJoazl1NmtqdHNmZmJvaDZvajAgZGV2QHdzbzIub3Jn&tok=MTkja3Jpc2hhbnRoYUB3c28yLmNvbWYyN2E1YjE4Mjg4YWYzYjc2ZDlhYzk4ZDU5Mjk2MmFlNGU3NTQ4YmU&ctz=Asia/Colombo&hl=en> >> Code review - System test framework >> Details: >> Project being reviewed: System Test Framework (Clarity) - Artifact >> Deployer classes. >> Link to crucible project: Will be posted once Crucible administrator >> finish ongoing configuration work. >> *When* >> Thu Apr 19 2:30pm – 3:30pm Colombo >> *Where* >> LK #59 2nd Floor Room >> (map<http://maps.google.lk/maps?q=LK+%2359+2nd+Floor+Room&hl=en> >> ) >> *Calendar* >> [email protected] >> *Who* >> • >> [email protected] - organizer >> • >> Chamara Silva >> • >> Dharshana Warusavitharana >> • >> [email protected] >> • >> Nuwan Wimalasekara >> • >> Dimuthu Leelarathne >> >> Going? >> ***Yes<https://www.google.com/calendar/event?action=RESPOND&eid=bTA3M3I3dDJoazl1NmtqdHNmZmJvaDZvajAgZGV2QHdzbzIub3Jn&rst=1&tok=MTkja3Jpc2hhbnRoYUB3c28yLmNvbWYyN2E1YjE4Mjg4YWYzYjc2ZDlhYzk4ZDU5Mjk2MmFlNGU3NTQ4YmU&ctz=Asia/Colombo&hl=en>- >> Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=bTA3M3I3dDJoazl1NmtqdHNmZmJvaDZvajAgZGV2QHdzbzIub3Jn&rst=3&tok=MTkja3Jpc2hhbnRoYUB3c28yLmNvbWYyN2E1YjE4Mjg4YWYzYjc2ZDlhYzk4ZDU5Mjk2MmFlNGU3NTQ4YmU&ctz=Asia/Colombo&hl=en>- >> No<https://www.google.com/calendar/event?action=RESPOND&eid=bTA3M3I3dDJoazl1NmtqdHNmZmJvaDZvajAgZGV2QHdzbzIub3Jn&rst=2&tok=MTkja3Jpc2hhbnRoYUB3c28yLmNvbWYyN2E1YjE4Mjg4YWYzYjc2ZDlhYzk4ZDU5Mjk2MmFlNGU3NTQ4YmU&ctz=Asia/Colombo&hl=en> >> * **more options >> »<https://www.google.com/calendar/event?action=VIEW&eid=bTA3M3I3dDJoazl1NmtqdHNmZmJvaDZvajAgZGV2QHdzbzIub3Jn&tok=MTkja3Jpc2hhbnRoYUB3c28yLmNvbWYyN2E1YjE4Mjg4YWYzYjc2ZDlhYzk4ZDU5Mjk2MmFlNGU3NTQ4YmU&ctz=Asia/Colombo&hl=en> >> >> Invitation from Google Calendar <https://www.google.com/calendar/> >> >> You are receiving this courtesy email at the account [email protected] you >> are an attendee of this event. >> >> To stop receiving future notifications for this event, decline this >> event. Alternatively you can sign up for a Google account at >> https://www.google.com/calendar/ and control your notification settings >> for your entire calendar. >> >> _______________________________________________ >> Dev mailing list >> [email protected] >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > Kathiravelu Pradeeban. > Software Engineer. > Cloud Technologies Team. > WSO2 Inc. > > Blog: [Llovizna] http://kkpradeeban.blogspot.com/ > M: +94 776 477 976 > >
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
