Hi, According to the suggestions made on the code review I have modified the keystore verification method. Patch file is attached in the JIRA issue [1]
[1] https://wso2.org/jira/browse/CARBON-14081 Best Regards.. Manoj Kumara Software Engineer WSO2, Inc.; http://wso2.com Twitter: http://twitter.com/ManKuma Mobile: +94713448188 On Thu, May 9, 2013 at 8:54 AM, Ananda Manoj Kumara <[email protected]> wrote: > Hi AmilaM, > > I will follow the guideline from now on. Thanks .. > > > > Best Regards.. > > > Manoj Kumara > Software Engineer > WSO2, Inc.; http://wso2.com > > Twitter: http://twitter.com/ManKuma > Mobile: +94713448188 > > > On Wed, May 8, 2013 at 6:05 PM, Amila Maha Arachchi <[email protected]>wrote: > >> Its better to send the notes to the same thread where you sent the code >> review invitation. >> >> >> On Wed, May 8, 2013 at 5:17 PM, Ananda Manoj Kumara <[email protected]>wrote: >> >>> During the code review session conducted today >>> following suggestions made, >>> >>> >>> - Use default certificate signature(MD5 value) to validate the >>> certificate in keystore instead of CN value of the certificate >>> (CN=localhost, O=WSO2, L=Mountain View, ST=CA, C=US) >>> - Change the property on 'config-validation.xml' file which is >>> currently the CN value of the default certificate to certificate >>> signature >>> - Change variable naming suitable to certificates instead of current >>> naming which is more aligned with keystore >>> >>> The JIRA issue corresponding to the task [1] >>> >>> [1] https://wso2.org/jira/browse/CARBON-14081 >>> >>> >>> Thanks, >>> Manoj >>> >>> >>> Best Regards.. >>> >>> >>> Manoj Kumara >>> Software Engineer >>> WSO2, Inc.; http://wso2.com >>> >>> Twitter: http://twitter.com/ManKuma >>> Mobile: +94713448188 >>> >>> _______________________________________________ >>> Dev mailing list >>> [email protected] >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> *Amila Maharachchi* >> Technical Lead >> Member, Management Committee - Cloud & Platform TG >> WSO2, Inc.; http://wso2.com >> >> Blog: http://maharachchi.blogspot.com >> Mobile: +94719371446 >> >> >
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
