Hi,
Yes it is redundant. Resolved the issue after that refactoring with
mentioning the reason.
Thanks
On Wed, Jul 24, 2013 at 10:38 PM, Senaka Fernando <sen...@wso2.com> wrote:
> Hi Shelan,
>
> This code is no longer in use AFAIU, so we can remove it.
>
> Thanks,
> Senaka.
>
>
> On Wed, Jul 24, 2013 at 2:53 PM, Shelan Perera <she...@wso2.com> wrote:
>
>> Hi,
>>
>> As i have discussed offline with Sameera it is not advisable to retrieve
>> server data because when tenant users access the registry this information
>> is more privileged to tennant users than its level.We are using this code
>> to compute atom URL [1].
>>
>> Due to this we have problems when browsing registry in tennant mode [2]
>>
>> org.wso2.carbon.registry.common.ui.utils.UIUtil::getAtomURL()
>>
>>
>> * ServerData data = client.getServerData();*
>> if (data != null && data.getRegistryType() != null
>> && data.getRegistryType().equals("remote")) {
>> remoteRegistryURL = data.getRemoteRegistryURL();
>> if (data.getRemoteRegistryChroot() != null &&
>>
>> !data.getRemoteRegistryChroot().equals(RegistryConstants.PATH_SEPARATOR)) {
>> chroot = data.getRemoteRegistryChroot();
>> if
>> (!chroot.startsWith(RegistryConstants.PATH_SEPARATOR)) {
>> chroot = RegistryConstants.PATH_SEPARATOR +
>> chroot;
>> }
>> if
>> (chroot.endsWith(RegistryConstants.PATH_SEPARATOR)) {
>> chroot = chroot.substring(0, chroot.length() -
>> RegistryConstants.PATH_SEPARATOR.length());
>> }
>> }
>> }
>>
>>
>> Solution is to get rid of this code. Please share if you have any
>> concerns over this.
>>
>> [1]
>> https://svn.wso2.org/repos/wso2/carbon/platform/trunk/components/registry/org.wso2.carbon.registry.common.ui/src/main/java/org/wso2/carbon/registry/common/ui/utils/UIUtil.java
>>
>>
>> [2] https://wso2.org/jira/browse/REGISTRY-1684
>> Thanks
>>
>> --
>> *Shelan Perera*
>>
>> Senior Software Engineer
>> **
>> Integration Technology Group
>> *WSO2, Inc. : wso2.com*
>> lean.enterprise.middleware.
>>
>> *Blog* : blog.shelan.org
>> *Linked-i*n : http://www.linkedin.com/pub/shelan-perera/a/194/465
>> *Twitter* : https://twitter.com/#!/shelan
>>
>> *Mobile* : +94 772 604 402
>>
>>
>
>
> --
> * <http://us13.wso2con.com/>
> *
> *
> *
> *Senaka Fernando*
> Senior Technical Lead; WSO2 Inc.; http://wso2.com*
> Member; Apache Software Foundation; http://apache.org
>
> E-mail: senaka AT wso2.com
> **P: +1 408 754 7388; ext: 51736*; *M: +94 77 322 1818
> Linked-In: http://linkedin.com/in/senakafernando
>
> *Lean . Enterprise . Middleware
>
--
*Shelan Perera*
Senior Software Engineer
**
Integration Technology Group
*WSO2, Inc. : wso2.com*
lean.enterprise.middleware.
*Blog* : blog.shelan.org
*Linked-i*n : http://www.linkedin.com/pub/shelan-perera/a/194/465
*Twitter* : https://twitter.com/#!/shelan
*Mobile* : +94 772 604 402
_______________________________________________
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev
