Hi Azeez,
I grepped the class:
nirmal@nirmal:/media/wso2/carbon/platform/trunk/components/load-balancer/lb-endpoint/org.wso2.carbon.lb.endpoint$
grep -nr log.isDebug
./src/main/java/org/wso2/carbon/lb/endpoint/endpoint/TenantAwareLoadBalanceEndpoint.java
142: if (log.isDebugEnabled()) {
268: if (log.isDebugEnabled()) {
nirmal@nirmal:/media/wso2/carbon/platform/trunk/components/load-balancer/lb-endpoint/org.wso2.carbon.lb.endpoint$
nirmal@nirmal:/media/wso2/carbon/platform/trunk/components/load-balancer/lb-endpoint/org.wso2.carbon.lb.endpoint$
nirmal@nirmal:/media/wso2/carbon/platform/trunk/components/load-balancer/lb-endpoint/org.wso2.carbon.lb.endpoint$
nirmal@nirmal:/media/wso2/carbon/platform/trunk/components/load-balancer/lb-endpoint/org.wso2.carbon.lb.endpoint$
nirmal@nirmal:/media/wso2/carbon/platform/trunk/components/load-balancer/lb-endpoint/org.wso2.carbon.lb.endpoint$
nirmal@nirmal:/media/wso2/carbon/platform/trunk/components/load-balancer/lb-endpoint/org.wso2.carbon.lb.endpoint$
grep -nr log.debug
./src/main/java/org/wso2/carbon/lb/endpoint/endpoint/TenantAwareLoadBalanceEndpoint.java
143: log.debug("Group management agent added
to cluster domain: " +
269: log.debug("Current session id : " +
sessionInformation.getId());
299: log.debug("************* Actual Host: "+actualHost +" ******
Target Host: "+targetHost);
328: log.debug("************* Actual Host: "+actualHost
+" ****** Target Host: "+targetHost);
431: log.debug("Setting host name: "+host);
454: log.debug("Retrying to a failed member has stopped.");
nirmal@nirmal
:/media/wso2/carbon/platform/trunk/components/load-balancer/lb-endpoint/org.wso2.carbon.lb.endpoint$
Those in green are wrapped using log.isDebugEnabled.
One in beige has no concatenation.
I guess the concern is on ones in red. +1 for wrapping those.
On Fri, Aug 16, 2013 at 4:43 PM, Afkham Azeez <[email protected]> wrote:
> There are a number of debug statements which do String concatenations, and
> are not wrapped in log.isDebugEnabled() conditions. Such statements will
> cause unnecessary performance overhead.
>
> --
> *Afkham Azeez*
> Director of Architecture; WSO2, Inc.; http://wso2.com
> Member; Apache Software Foundation; http://www.apache.org/
> * <http://www.apache.org/>**
> email: **[email protected]* <[email protected]>* cell: +94 77 3320919
> blog: **http://blog.afkham.org* <http://blog.afkham.org>*
> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
> *
> linked-in: **http://lk.linkedin.com/in/afkhamazeez*
> *
> *
> *Lean . Enterprise . Middleware*
>
--
Thanks & regards,
Nirmal
Senior Software Engineer- Platform Technologies Team, WSO2 Inc.
Mobile: +94715779733
Blog: http://nirmalfdo.blogspot.com/
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev
