On Mon, Jun 2, 2014 at 5:05 PM, Sagara Gunathunga <sag...@wso2.com> wrote:
> > > I can see two problems here. > > 1. People sending pull requests to "WSO2" account instead of "WSO2-dev" > > This is mentioned in number of mails and I have clearly explained the > procedure during my training last week. We can't control external people > but we should able to educate WSO2 internal people to use proper GitHub > repo. > > 2. Though someone send a pull request to "WSO2" account PR builder should > not trigger unless the author is white-listed. Here there should be a issue > with job configuration or with feature it self. > We tested on AS repos to verify the behaviour and it seems AS jobs are working properly [ref - https://github.com/wso2/carbon-deployment/pull/10 ] hence this should be a job configuration issue. Thanks ! > > Thanks ! > > > On Mon, Jun 2, 2014 at 4:52 PM, Vanjikumaran Sivajothy <va...@wso2.com> > wrote: > >> Hi manula, >> >> You have send the pull request to synapse in wso2 repository straightway >> and it is not acceptable according to protocol on continuous delivery on >> GIThub. According to the mail thread "Guidelines to move project into >> GitHub" and "Meeting notes : Governance for Git based builds - initial >> discussion", You should have forked the repo to your GIT account and send >> the pull request to wso2-dev [2]. Once you send the pull request ESB team >> will review the change and merge the code in to master repo. >> >> Since you have send pull request and it merged the code in the wso2 >> repo[3], Currently ESB team's code in wso2-dev giving merge conflicts while >> sych with main repo. >> >> Therefore, please remove your code in main repo and send proper pull >> request to the wso2-dev[2] >> >> Thank you in advance! >> >> >> @mahesika >> Based on [1], It seems like white list for synapse is not properly >> configured. >> can you please recheck it again? >> >> >> >> [1] >> https://github.com/wso2/wso2-synapse/commit/19cd26ce92e438e4dd3bf3688c57594bb54f3400 >> >> [2] https://github.com/wso2-dev/wso2-synapse >> >> [3]https://github.com/wso2/wso2-synapse >> >> Best Regards, >> vanji >> -- >> Sivajothy Vanjikumaran >> *Senior Software Engineer* >> *Integration Technologies Team* >> *WSO2 Inc. http://wso2.com <http://wso2.com/>* >> *Mobile:(+94)777219209* >> [image: Facebook] <https://www.facebook.com/vanjikumaran> [image: >> Twitter] <https://twitter.com/vanjikumaran> [image: LinkedIn] >> <http://www.linkedin.com/pub/vanjikumaran-sivajothy/25/b31/293> [image: >> Blogger] <http://vanjikumaran.blogspot.com/> [image: SlideShare] >> <http://www.slideshare.net/vanjikumaran> >> >> This communication may contain privileged or other >> confidential information and is intended exclusively for the addressee/s. >> If you are not the intended recipient/s, or believe that you may >> have received this communication in error, please reply to the >> sender indicating that fact and delete the copy you received and in >> addition, you should not print, copy, re-transmit, disseminate, or >> otherwise use the information contained in this communication. >> Internet communications cannot be guaranteed to be timely, secure, error >> or virus-free. The sender does not accept liability for any errors >> or omissions >> > > > > -- > Sagara Gunathunga > > Senior Technical Lead; WSO2, Inc.; http://wso2.com > V.P Apache Web Services; http://ws.apache.org/ > Linkedin; http://www.linkedin.com/in/ssagara > Blog ; http://ssagara.blogspot.com > > -- Sagara Gunathunga Senior Technical Lead; WSO2, Inc.; http://wso2.com V.P Apache Web Services; http://ws.apache.org/ Linkedin; http://www.linkedin.com/in/ssagara Blog ; http://ssagara.blogspot.com
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
