Hi Shameera, Attached the new patch with modifications. Ran tests. No new test failures, AFAIU.
thanks,. On Thu, Jul 10, 2014 at 5:12 PM, Pradeep Fernando <[email protected]> wrote: > Hi, > > will attach the patch again. However, encountered some registry test > failures in patch0009/registry.core without my patch. > > thanks > > > On Thu, Jul 10, 2014 at 4:46 PM, Shameera Rathnayaka <[email protected]> > wrote: > >> Hi Pradeep, >> >> you have introduced a new API in your patch , please remove that as it is >> incorrect to do API changes with a patch. But when you provide a pull >> request to 4.3.0 you can do any API changes. >> >> Thanks, >> Shameera. >> >> >> On Thu, Jul 10, 2014 at 3:47 PM, Pradeep Fernando <[email protected]> >> wrote: >> >>> Hi Kernel team, >>> >>> Please review and merge the changes please. >>> >>> https://wso2.org/jira/browse/CARBON-14861 >>> >>> thanks >>> >> >> >> >> -- >> *Software Engineer - WSO2 Inc.* >> *email: shameera AT wso2.com <[email protected]> , shameera AT apache.org >> <[email protected]>* >> *phone: +9471 922 1454 <%2B9471%20922%201454>* >> >> *Linked in : *http://lk.linkedin.com/pub/shameera-rathnayaka/1a/661/561 >> *Twitter : *https://twitter.com/Shameera_R >> > > > > -- > *Pradeep Fernando* > Associate Technical Lead;WSO2 Inc.; http://wso2.com > > blog: http://pradeepfernando.blogspot.com > m: +94776603662 > -- *Pradeep Fernando* Associate Technical Lead;WSO2 Inc.; http://wso2.com blog: http://pradeepfernando.blogspot.com m: +94776603662
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
