Hi Pradeep, Which jdk version you are using to buile the kernel? if it is 1.7 then you probably hit with registry test failures.
I will apply the new patch. Thanks, Shameera On Thu, Jul 10, 2014 at 5:22 PM, Pradeep Fernando <prad...@wso2.com> wrote: > Hi Shameera, > > Attached the new patch with modifications. Ran tests. No new test > failures, AFAIU. > > thanks,. > > > On Thu, Jul 10, 2014 at 5:12 PM, Pradeep Fernando <prad...@wso2.com> > wrote: > >> Hi, >> >> will attach the patch again. However, encountered some registry test >> failures in patch0009/registry.core without my patch. >> >> thanks >> >> >> On Thu, Jul 10, 2014 at 4:46 PM, Shameera Rathnayaka <shame...@wso2.com> >> wrote: >> >>> Hi Pradeep, >>> >>> you have introduced a new API in your patch , please remove that as it >>> is incorrect to do API changes with a patch. But when you provide a pull >>> request to 4.3.0 you can do any API changes. >>> >>> Thanks, >>> Shameera. >>> >>> >>> On Thu, Jul 10, 2014 at 3:47 PM, Pradeep Fernando <prad...@wso2.com> >>> wrote: >>> >>>> Hi Kernel team, >>>> >>>> Please review and merge the changes please. >>>> >>>> https://wso2.org/jira/browse/CARBON-14861 >>>> >>>> thanks >>>> >>> >>> >>> >>> -- >>> *Software Engineer - WSO2 Inc.* >>> *email: shameera AT wso2.com <shame...@wso2.com> , shameera AT >>> apache.org <shame...@apache.org>* >>> *phone: +9471 922 1454 <%2B9471%20922%201454>* >>> >>> *Linked in : *http://lk.linkedin.com/pub/shameera-rathnayaka/1a/661/561 >>> *Twitter : *https://twitter.com/Shameera_R >>> >> >> >> >> -- >> *Pradeep Fernando* >> Associate Technical Lead;WSO2 Inc.; http://wso2.com >> >> blog: http://pradeepfernando.blogspot.com >> m: +94776603662 >> > > > > -- > *Pradeep Fernando* > Associate Technical Lead;WSO2 Inc.; http://wso2.com > > blog: http://pradeepfernando.blogspot.com > m: +94776603662 > -- *Software Engineer - WSO2 Inc.* *email: shameera AT wso2.com <shame...@wso2.com> , shameera AT apache.org <shame...@apache.org>* *phone: +9471 922 1454* *Linked in : *http://lk.linkedin.com/pub/shameera-rathnayaka/1a/661/561 *Twitter : *https://twitter.com/Shameera_R
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
