On Tue, Mar 3, 2015 at 10:42 AM, Kishanthan Thangarajah <[email protected]
> wrote:

> Hi SupunM,
>
> There are two classes (Mapper.java and ContextConfig.java) that are not
> patched from the original tomcat source distribution which resides in the
> tomcat.patch component [1]. If they are not used for any requirement, shall
> we remove them? Having these will cause issues with API changes when we try
> to upgrade tomcat.
>

AFAIR these are important modifications did by KasunG, Sameera also
reviewed these changes at that time. Please wait KasunG's response before
proceed on this.

@KasunG, as a side note I remember I asked you to document these
customizations somewhere, if you have that doc please share with Carbon/AS
team members otherwise there is a high chance to loose these changes during
upgrades.

Thanks !

>
> Thanks,
> Kishanthan.
> [1]
> https://github.com/wso2/carbon-deployment/tree/master/components/webapp-mgt/org.wso2.carbon.tomcat.patch/src/main/java/org/apache
>
>
> --
> *Kishanthan Thangarajah*
> Senior Software Engineer,
> Platform Technologies Team,
> WSO2, Inc.
> lean.enterprise.middleware
>
> Mobile - +94773426635
> Blog - *http://kishanthan.wordpress.com <http://kishanthan.wordpress.com>*
> Twitter - *http://twitter.com/kishanthan <http://twitter.com/kishanthan>*
>
> _______________________________________________
> Dev mailing list
> [email protected]
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
Sagara Gunathunga

Senior Technical Lead; WSO2, Inc.;  http://wso2.com
V.P Apache Web Services;    http://ws.apache.org/
Linkedin; http://www.linkedin.com/in/ssagara
Blog ;  http://ssagara.blogspot.com
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to