I have removed the classes (Mapper and ContextConfig) from carbon-deployment/org.wso2.carbon.tomcat.patch component on java8support branch.
On Tue, Mar 3, 2015 at 1:20 PM, Sagara Gunathunga <[email protected]> wrote: > > > On Tue, Mar 3, 2015 at 1:19 PM, Supun Malinga <[email protected]> wrote: > >> Hi Sagara/ All, >> >> AFAIR we added Maper.java and ContextConfig.java for patching purposes >> but we later used alternative approaches. Let's remove if these are not >> patched and not used. >> > > +1 > > Thanks ! > >> >> thanks, >> >> On Tue, Mar 3, 2015 at 12:58 PM, Kishanthan Thangarajah < >> [email protected]> wrote: >> >>> >>> >>> On Tue, Mar 3, 2015 at 12:33 PM, KasunG Gajasinghe <[email protected]> >>> wrote: >>> >>>> Hi, >>>> >>>> >>>> On Tue, Mar 3, 2015 at 1:00 AM, Kishanthan Thangarajah < >>>> [email protected]> wrote: >>>> >>>>> >>>>> >>>>> On Tue, Mar 3, 2015 at 11:03 AM, Sagara Gunathunga <[email protected]> >>>>> wrote: >>>>> >>>>>> >>>>>> >>>>>> On Tue, Mar 3, 2015 at 10:42 AM, Kishanthan Thangarajah < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> Hi SupunM, >>>>>>> >>>>>>> There are two classes (Mapper.java and ContextConfig.java) that are >>>>>>> not patched from the original tomcat source distribution which resides >>>>>>> in >>>>>>> the tomcat.patch component [1]. If they are not used for any >>>>>>> requirement, >>>>>>> shall we remove them? Having these will cause issues with API changes >>>>>>> when >>>>>>> we try to upgrade tomcat. >>>>>>> >>>>>> >>>>>> AFAIR these are important modifications did by KasunG, Sameera also >>>>>> reviewed these changes at that time. Please wait KasunG's response before >>>>>> proceed on this. >>>>>> >>>>> >>>>> I think the above mentioned fixes are for *ExpandWar* class, to fix >>>>> the tenants webapp getting expanded into super tenants repository. This is >>>>> there in the tomcat.patch component. But the two classes which I mentioned >>>>> do not have an diff from original tomcat source. Anyway lets wait for the >>>>> confirmation. >>>>> >>>>> >>>> Yes, those changes were for ExpandWar class to fix the issue with >>>> webapp unpacking in tenants. >>>> >>>> It looks the Mapper class was added in Carbon 4.2.0 in revision >>>> r180112. Based on the commit message there, it was meant to be patched >>>> later on, but never was as I see. >>>> >>> >>> Same with ContextConfig class too, which is added with >>> da238f6bf46a959771972441e11157da9c875d3b. >>> >>>> >>>> >>>>> >>>>>> @KasunG, as a side note I remember I asked you to document these >>>>>> customizations somewhere, if you have that doc please share with >>>>>> Carbon/AS >>>>>> team members otherwise there is a high chance to loose these changes >>>>>> during >>>>>> upgrades. >>>>>> >>>>> >>>> I don't think we created such a doc. >>>> >>>> >>>>> >>>>> +1, this will definitely help to avoid such issues with tomcat >>>>> upgrades. >>>>> >>>>>> >>>>>> Thanks ! >>>>>> >>>>>>> >>>>>>> Thanks, >>>>>>> Kishanthan. >>>>>>> [1] >>>>>>> https://github.com/wso2/carbon-deployment/tree/master/components/webapp-mgt/org.wso2.carbon.tomcat.patch/src/main/java/org/apache >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> *Kishanthan Thangarajah* >>>>>>> Senior Software Engineer, >>>>>>> Platform Technologies Team, >>>>>>> WSO2, Inc. >>>>>>> lean.enterprise.middleware >>>>>>> >>>>>>> Mobile - +94773426635 >>>>>>> Blog - *http://kishanthan.wordpress.com >>>>>>> <http://kishanthan.wordpress.com>* >>>>>>> Twitter - *http://twitter.com/kishanthan >>>>>>> <http://twitter.com/kishanthan>* >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Dev mailing list >>>>>>> [email protected] >>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Sagara Gunathunga >>>>>> >>>>>> Senior Technical Lead; WSO2, Inc.; http://wso2.com >>>>>> V.P Apache Web Services; http://ws.apache.org/ >>>>>> Linkedin; http://www.linkedin.com/in/ssagara >>>>>> Blog ; http://ssagara.blogspot.com >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Kishanthan Thangarajah* >>>>> Senior Software Engineer, >>>>> Platform Technologies Team, >>>>> WSO2, Inc. >>>>> lean.enterprise.middleware >>>>> >>>>> Mobile - +94773426635 >>>>> Blog - *http://kishanthan.wordpress.com >>>>> <http://kishanthan.wordpress.com>* >>>>> Twitter - *http://twitter.com/kishanthan >>>>> <http://twitter.com/kishanthan>* >>>>> >>>> >>>> >>>> >>>> -- >>>> >>>> *Kasun Gajasinghe*Senior Software Engineer, WSO2 Inc. >>>> email: kasung AT spamfree wso2.com >>>> linked-in: http://lk.linkedin.com/in/gajasinghe >>>> blog: http://kasunbg.org >>>> >>>> >>>> >>> >>> >>> >>> -- >>> *Kishanthan Thangarajah* >>> Senior Software Engineer, >>> Platform Technologies Team, >>> WSO2, Inc. >>> lean.enterprise.middleware >>> >>> Mobile - +94773426635 >>> Blog - *http://kishanthan.wordpress.com >>> <http://kishanthan.wordpress.com>* >>> Twitter - *http://twitter.com/kishanthan >>> <http://twitter.com/kishanthan>* >>> >> >> >> >> -- >> Supun Malinga, >> >> Senior Software Engineer, >> WSO2 Inc. >> http://wso2.com >> email: [email protected] <[email protected]> >> mobile: +94 (0)71 56 91 321 >> > > > > -- > Sagara Gunathunga > > Senior Technical Lead; WSO2, Inc.; http://wso2.com > V.P Apache Web Services; http://ws.apache.org/ > Linkedin; http://www.linkedin.com/in/ssagara > Blog ; http://ssagara.blogspot.com > > -- *Kishanthan Thangarajah* Senior Software Engineer, Platform Technologies Team, WSO2, Inc. lean.enterprise.middleware Mobile - +94773426635 Blog - *http://kishanthan.wordpress.com <http://kishanthan.wordpress.com>* Twitter - *http://twitter.com/kishanthan <http://twitter.com/kishanthan>*
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
