Hi Samith, Yes you are correct, we can make the end user oriented message in another layer other than the module layer. So throwing e is fine i guess. Thanks everyone!
On Mon, Mar 16, 2015 at 5:45 PM, Samith Dassanayake <[email protected]> wrote: > Hi Mahesh, > IMHO I think from the module layer, we should throw the exception with > required additional details along with the exception. In block layer, we > should log it and set the response with the correct error code and > content(content should be a simple end user oriented message)[1], before > return to the user. If you set it correctly then it will be directed > to OnFailure callback of the caller and you can do what ever client level > exception handling over there > > [1] http://jaggeryjs.org/documentation.jag?api=response > > Thanks, > Samith > > On Mon, Mar 16, 2015 at 2:50 AM, Gayan Dhanushka <[email protected]> wrote: > >> Hi Mahesh, >> >> +1 for throwing an error message. >> >> A message of the format mentioned above would be good for logging. IMO >> throwing a simple message is enough to be displayed to the user. >> >> Regards >> Gayan >> >> On Mon, Mar 16, 2015 at 3:00 PM, Danushka Fernando <[email protected]> >> wrote: >> >>> We dont need to give that detailed error message to the user. But having >>> an error message saying what has been failed like jenkins job creation >>> failed or git repo creation failed would be good IMO. >>> >>> Thanks & Regards >>> Danushka Fernando >>> Software Engineer >>> WSO2 inc. http://wso2.com/ >>> Mobile : +94716332729 >>> >>> On Mon, Mar 16, 2015 at 2:53 PM, Mahesh Chinthaka <[email protected]> >>> wrote: >>> >>>> Hi, >>>> +1 for throwing the message. >>>> But another question, >>>> At the moment we have put all details possible for the message. eg: >>>> tenant domain, username ,application type etc. >>>> But when it comes to user (front end) i think message should be simple. >>>> >>>> For an example. >>>> Lets say an error occurred while creating an application. >>>> >>>> should the message diplayed on the UI be like , >>>> var msg = " Application creation failed!!" >>>> or >>>> var msg = "Error while creating application : " + applicationName + " >>>> with application key : " + applicationKey >>>> + " of application type : " + applicationType + " and >>>> version : " + version + " for the user : " >>>> + userName + " of tenant domain : " + tenantDomain + >>>> ". >>>> >>>> On Mon, Mar 16, 2015 at 2:44 PM, Danushka Fernando <[email protected]> >>>> wrote: >>>> >>>>> Since this is about sending an error message for front end IMO both >>>>> ways are ok for me. And since we are showing the error message we are >>>>> throwing I guess we need to throw the message. >>>>> >>>>> Thanks & Regards >>>>> Danushka Fernando >>>>> Software Engineer >>>>> WSO2 inc. http://wso2.com/ >>>>> Mobile : +94716332729 >>>>> >>>>> On Mon, Mar 16, 2015 at 2:40 PM, Mahesh Chinthaka <[email protected]> >>>>> wrote: >>>>> >>>>>> Hi all, >>>>>> >>>>>> In AF appmgt module layer, >>>>>> when we catch a exception what is the correct way to handle it. >>>>>> >>>>>> var msg = "Some error msg"; >>>>>> log.error(msg); >>>>>> log.error(e); >>>>>> *throw e; * >>>>>> or >>>>>> *throw msg;* >>>>>> >>>>>> In appfactory we get the error message thrown in the module layer to >>>>>> front and display it in UI in the top section of the page with a red bar. >>>>>> So if we thew e, the GUI will get a big error message displayed with >>>>>> all the stack trace details. >>>>>> >>>>>> >>>>>> Whats the best way ?? >>>>>> >>>>>> -- >>>>>> *Mahesh Chinthaka Vidanagama* | Software Engineer >>>>>> WSO2, Inc | lean. enterprise. middleware. >>>>>> #20, Palm Grove, Colombo 03, Sri Lanka >>>>>> Mobile: +94 71 63 63 083 | Work: +94 112 145 345 >>>>>> Email: [email protected] | Web: www.wso2.com >>>>>> >>>>>> _______________________________________________ >>>>>> Dev mailing list >>>>>> [email protected] >>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>> >>>>>> >>>>> >>>> >>>> >>>> -- >>>> *Mahesh Chinthaka Vidanagama* | Software Engineer >>>> WSO2, Inc | lean. enterprise. middleware. >>>> #20, Palm Grove, Colombo 03, Sri Lanka >>>> Mobile: +94 71 63 63 083 | Work: +94 112 145 345 >>>> Email: [email protected] | Web: www.wso2.com >>>> >>> >>> >>> _______________________________________________ >>> Dev mailing list >>> [email protected] >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> Gayan Dhanuska >> Software Engineer >> http://wso2.com/ >> Lean Enterprise Middleware >> >> Mobile >> 071 666 2327 >> >> Office >> Tel : 94 11 214 5345 >> Fax : 94 11 214 5300 >> >> Twitter : https://twitter.com/gayanlggd >> >> _______________________________________________ >> Dev mailing list >> [email protected] >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > Best Regards > > Samith Dassanayake > Software Engineer | Cloud TG > WSO2, Inc. | http://wso2.com > lean. enterprise. middleware > > Mobile : +947 76207351 > -- *Mahesh Chinthaka Vidanagama* | Software Engineer WSO2, Inc | lean. enterprise. middleware. #20, Palm Grove, Colombo 03, Sri Lanka Mobile: +94 71 63 63 083 | Work: +94 112 145 345 Email: [email protected] | Web: www.wso2.com
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
