Hi Manoj/Supun Jira created to track on [1]
@Manoj: other than xml processing improvement i have added all the things mentioned in the code review. [1] https://wso2.org/jira/browse/WSAS-1955 On Wed, Jun 3, 2015 at 10:38 AM, Supun Malinga <[email protected]> wrote: > > > On Wed, Jun 3, 2015 at 10:34 AM, Shashika Karunatilaka <[email protected] > > wrote: > >> Hi Manoj >> >> As per discussion i had with sameera, it will be done in the future as a >> enhancement. >> > > Let's create a jira to track this.. > > thanks, > >> >> Thank you. >> >> On Wed, Jun 3, 2015 at 10:26 AM, Manoj Kumara <[email protected]> wrote: >> >>> Hi Shashika, >>> >>> Can you check the pull request with the suggestions of the last code >>> review. IIRC we suggested to remove usage of axiom for xml processing. >>> >>> Regards, >>> Manoj >>> >>> >>> *Manoj Kumara* >>> Software Engineer >>> WSO2 Inc. http://wso2.com/ >>> *lean.enterprise.middleware* >>> Mobile: +94713448188 >>> >>> On Tue, Jun 2, 2015 at 9:12 PM, Shashika Karunatilaka < >>> [email protected]> wrote: >>> >>>> Please review and merge the implementation of feature [2] and test >>>> cases [3] on JIRA [1] >>>> >>>> [1] https://wso2.org/jira/browse/WSAS-1954 >>>> [2] https://github.com/wso2/carbon-deployment/pull/99 >>>> [3] https://github.com/wso2/product-as/pull/70 >>>> >>>> -- >>>> Shashika Prabath Karunatilaka, >>>> Software Engineer, >>>> WSO2, Inc: http://wso2.com/ >>>> mobile : +94 77 7487792 >>>> >>>> _______________________________________________ >>>> Dev mailing list >>>> [email protected] >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >> >> >> -- >> Shashika Prabath Karunatilaka, >> Software Engineer, >> WSO2, Inc: http://wso2.com/ >> mobile : +94 77 7487792 >> >> _______________________________________________ >> Dev mailing list >> [email protected] >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > Supun Malinga, > > Senior Software Engineer, > WSO2 Inc. > http://wso2.com > email: [email protected] <[email protected]> > mobile: +94 (0)71 56 91 321 > -- Shashika Prabath Karunatilaka, Software Engineer, WSO2, Inc: http://wso2.com/ mobile : +94 77 7487792
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
