Hi Shashika, In addition to the one mentioned above, following code review note awaits attention. [1] Please make sure to attend this too.
I have merged the pull request, and changed the jira to a L2 and the fix version as AS6. [1] No need to check if parameter is empty in TomcatCxfDiscoveryListner.getWadlUri method On Sat, Jun 6, 2015 at 7:26 AM, KasunG Gajasinghe <[email protected]> wrote: > Hi, > > I have made some changes to the document. @Nilmini, please make sure to > integrate the suggestions if you have aleady started adding this to AS6 > docs. > > Thanks > > On Fri, Jun 5, 2015 at 11:44 AM, Shashika Karunatilaka <[email protected] > > wrote: > >> Hi Nilmini, >> >> Please find the Documentation link[1] for ws-discovery feature. >> >> [1] >> https://docs.google.com/document/d/1DH83Dh9eKLqIglFBTaKHG12yV5dw_LmR_JkOEIo9evo/edit#heading=h.z6c7wruwli2j >> >> Thank you. >> >> On Wed, Jun 3, 2015 at 10:48 AM, Shashika Karunatilaka < >> [email protected]> wrote: >> >>> Hi Manoj/Supun >>> >>> Jira created to track on [1] >>> >>> @Manoj: other than xml processing improvement i have added all the >>> things mentioned in the code review. >>> >>> [1] https://wso2.org/jira/browse/WSAS-1955 >>> >>> On Wed, Jun 3, 2015 at 10:38 AM, Supun Malinga <[email protected]> wrote: >>> >>>> >>>> >>>> On Wed, Jun 3, 2015 at 10:34 AM, Shashika Karunatilaka < >>>> [email protected]> wrote: >>>> >>>>> Hi Manoj >>>>> >>>>> As per discussion i had with sameera, it will be done in the future as >>>>> a enhancement. >>>>> >>>> >>>> Let's create a jira to track this.. >>>> >>>> thanks, >>>> >>>>> >>>>> Thank you. >>>>> >>>>> On Wed, Jun 3, 2015 at 10:26 AM, Manoj Kumara <[email protected]> wrote: >>>>> >>>>>> Hi Shashika, >>>>>> >>>>>> Can you check the pull request with the suggestions of the last code >>>>>> review. IIRC we suggested to remove usage of axiom for xml processing. >>>>>> >>>>>> Regards, >>>>>> Manoj >>>>>> >>>>>> >>>>>> *Manoj Kumara* >>>>>> Software Engineer >>>>>> WSO2 Inc. http://wso2.com/ >>>>>> *lean.enterprise.middleware* >>>>>> Mobile: +94713448188 >>>>>> >>>>>> On Tue, Jun 2, 2015 at 9:12 PM, Shashika Karunatilaka < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> Please review and merge the implementation of feature [2] and test >>>>>>> cases [3] on JIRA [1] >>>>>>> >>>>>>> [1] https://wso2.org/jira/browse/WSAS-1954 >>>>>>> [2] https://github.com/wso2/carbon-deployment/pull/99 >>>>>>> [3] https://github.com/wso2/product-as/pull/70 >>>>>>> >>>>>>> -- >>>>>>> Shashika Prabath Karunatilaka, >>>>>>> Software Engineer, >>>>>>> WSO2, Inc: http://wso2.com/ >>>>>>> mobile : +94 77 7487792 >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Dev mailing list >>>>>>> [email protected] >>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>>> >>>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Shashika Prabath Karunatilaka, >>>>> Software Engineer, >>>>> WSO2, Inc: http://wso2.com/ >>>>> mobile : +94 77 7487792 >>>>> >>>>> _______________________________________________ >>>>> Dev mailing list >>>>> [email protected] >>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>> >>>>> >>>> >>>> >>>> -- >>>> Supun Malinga, >>>> >>>> Senior Software Engineer, >>>> WSO2 Inc. >>>> http://wso2.com >>>> email: [email protected] <[email protected]> >>>> mobile: +94 (0)71 56 91 321 >>>> >>> >>> >>> >>> -- >>> Shashika Prabath Karunatilaka, >>> Software Engineer, >>> WSO2, Inc: http://wso2.com/ >>> mobile : +94 77 7487792 >>> >> >> >> >> -- >> Shashika Prabath Karunatilaka, >> Software Engineer, >> WSO2, Inc: http://wso2.com/ >> mobile : +94 77 7487792 >> >> _______________________________________________ >> Dev mailing list >> [email protected] >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > > *Kasun Gajasinghe*Senior Software Engineer, WSO2 Inc. > email: kasung AT spamfree wso2.com > linked-in: http://lk.linkedin.com/in/gajasinghe > blog: http://kasunbg.org > > > -- *Kasun Gajasinghe*Senior Software Engineer, WSO2 Inc. email: kasung AT spamfree wso2.com linked-in: http://lk.linkedin.com/in/gajasinghe blog: http://kasunbg.org
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
