Hi Gayan,

On Tue, Oct 6, 2015 at 11:17 PM, Gayan Gunawardana <[email protected]> wrote:

> Hi Darshana,
>
> I also experienced NPE in federated SAML SSO use case. Should be fixed
> with following changes you have added.
>

Yes, we had this NPE earlier and as mentioned above its fixed with
https://github.com/wso2/carbon-identity/commit/1d9bb6763c740c0e39b741f30a0d11d88c37bebc


If you see any other NPEs in any authenication flow, please raise a JIRA.

Thanks,
Darshana.


> - cacheEntry = new SessionContextCacheEntry(sessionContextDO); + if
> (sessionContextDO != null) { + cacheEntry = new SessionContextCacheEntry
> (sessionContextDO); + }
>
> Thanks,
> Gayan
>
> On Tue, Oct 6, 2015 at 6:44 PM, Charitha Goonetilleke <[email protected]>
> wrote:
>
>> Hi All,
>>
>> I tried with latest commits and seems, $subject is solved with latest
>> changes.
>>
>> Thanks,
>> /charithag
>>
>> On Tue, Oct 6, 2015 at 3:20 PM, Darshana Gunawardana <[email protected]>
>> wrote:
>>
>>>
>>>
>>> On Tue, Oct 6, 2015 at 2:21 PM, Hasintha Indrajee <[email protected]>
>>> wrote:
>>>
>>>> Seems like this issue occurs since the session key you send with your
>>>> second request  is no longer there in the server side and it gives this
>>>> error. Did you check this in the latest code base ? Can you confirm that
>>>> this is still there in the latest code base.
>>>>
>>>
>>> Yes this is fixed with :
>>> https://github.com/wso2/carbon-identity/commit/1d9bb6763c740c0e39b741f30a0d11d88c37bebc
>>>
>>>
>>>> If this is still there, please open a jira for this issue.
>>>>
>>>
>>> +1 Create a L1 if you see any NPEs on this flow.
>>>
>>> Thanks,
>>> Darshana
>>>
>>>>
>>>> On Tue, Oct 6, 2015 at 1:34 PM, Charitha Goonetilleke <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi All,
>>>>>
>>>>> I'm using carbon.identity.version 4.6.0-SNAPSHOT with IoT Server for
>>>>> testing. $subject occurred when I tried to login in to store/publisher. It
>>>>> further saying, "Something went wrong during the authentication process.
>>>>> Please try signing in again." Also in console printing a Null Pointer
>>>>> Exception[1].
>>>>>
>>>>> This is the way to reproduce the issue.
>>>>>
>>>>>    - Extract a pack with carbon.identity.version 4.6.0-SNAPSHOT from
>>>>>    zip archive.
>>>>>    - Run pack and try to login as admin
>>>>>    - Shutdown the pack and delete all files of pack.
>>>>>    - Extract pack again from zip archive.
>>>>>    - Run pack and try to login.
>>>>>
>>>>> Exception [1]
>>>>>
>>>>> [2015-10-06 12:38:23,902] ERROR
>>>>> {org.wso2.carbon.identity.application.authentication.framework.handler.request.impl.DefaultRequestCoordinator}
>>>>> -  Exception in Authentication Framework
>>>>> java.lang.NullPointerException
>>>>> at
>>>>> org.wso2.carbon.identity.application.authentication.framework.cache.SessionContextCacheEntry.<init>(SessionContextCacheEntry.java:40)
>>>>> at
>>>>> org.wso2.carbon.identity.application.authentication.framework.cache.SessionContextCache.getValueFromCache(SessionContextCache.java:95)
>>>>> at
>>>>> org.wso2.carbon.identity.application.authentication.framework.util.FrameworkUtils.getSessionContextFromCache(FrameworkUtils.java:592)
>>>>> at
>>>>> org.wso2.carbon.identity.application.authentication.framework.handler.request.impl.DefaultRequestCoordinator.findPreviousAuthenticatedSession(DefaultRequestCoordinator.java:284)
>>>>> at
>>>>> org.wso2.carbon.identity.application.authentication.framework.handler.request.impl.DefaultRequestCoordinator.initializeFlow(DefaultRequestCoordinator.java:222)
>>>>> at
>>>>> org.wso2.carbon.identity.application.authentication.framework.handler.request.impl.DefaultRequestCoordinator.handle(DefaultRequestCoordinator.java:103)
>>>>> at
>>>>> org.wso2.carbon.identity.application.authentication.framework.servlet.CommonAuthenticationServlet.doPost(CommonAuthenticationServlet.java:53)
>>>>> at
>>>>> org.wso2.carbon.identity.application.authentication.framework.servlet.CommonAuthenticationServlet.doGet(CommonAuthenticationServlet.java:43)
>>>>> at javax.servlet.http.HttpServlet.service(HttpServlet.java:620)
>>>>> at javax.servlet.http.HttpServlet.service(HttpServlet.java:727)
>>>>> at
>>>>> org.eclipse.equinox.http.helper.ContextPathServletAdaptor.service(ContextPathServletAdaptor.java:37)
>>>>> at
>>>>> org.eclipse.equinox.http.servlet.internal.ServletRegistration.service(ServletRegistration.java:61)
>>>>> at
>>>>> org.eclipse.equinox.http.servlet.internal.ProxyServlet.processAlias(ProxyServlet.java:128)
>>>>> at
>>>>> org.eclipse.equinox.http.servlet.internal.ProxyServlet.service(ProxyServlet.java:60)
>>>>> at javax.servlet.http.HttpServlet.service(HttpServlet.java:727)
>>>>> at
>>>>> org.wso2.carbon.tomcat.ext.servlet.DelegationServlet.service(DelegationServlet.java:68)
>>>>> at
>>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)
>>>>> at
>>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
>>>>> at
>>>>> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>>>>> at
>>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
>>>>> at
>>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
>>>>> at
>>>>> org.wso2.carbon.tomcat.ext.filter.CharacterSetFilter.doFilter(CharacterSetFilter.java:61)
>>>>> at
>>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
>>>>> at
>>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
>>>>> at
>>>>> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:220)
>>>>> at
>>>>> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:122)
>>>>> at
>>>>> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:504)
>>>>> at
>>>>> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:170)
>>>>> at
>>>>> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103)
>>>>> at
>>>>> org.wso2.carbon.tomcat.ext.valves.CompositeValve.continueInvocation(CompositeValve.java:99)
>>>>> at
>>>>> org.wso2.carbon.tomcat.ext.valves.CarbonTomcatValve$1.invoke(CarbonTomcatValve.java:47)
>>>>> at
>>>>> org.wso2.carbon.webapp.mgt.TenantLazyLoaderValve.invoke(TenantLazyLoaderValve.java:57)
>>>>> at
>>>>> org.wso2.carbon.webapp.authenticator.framework.WebappAuthenticationHandler.invoke(WebappAuthenticationHandler.java:43)
>>>>> at
>>>>> org.wso2.carbon.event.receiver.core.internal.tenantmgt.TenantLazyLoaderValve.invoke(TenantLazyLoaderValve.java:48)
>>>>> at
>>>>> org.wso2.carbon.tomcat.ext.valves.TomcatValveContainer.invokeValves(TomcatValveContainer.java:47)
>>>>> at
>>>>> org.wso2.carbon.tomcat.ext.valves.CompositeValve.invoke(CompositeValve.java:62)
>>>>> at
>>>>> org.wso2.carbon.tomcat.ext.valves.CarbonStuckThreadDetectionValve.invoke(CarbonStuckThreadDetectionValve.java:159)
>>>>> at
>>>>> org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:950)
>>>>> at
>>>>> org.wso2.carbon.tomcat.ext.valves.CarbonContextCreatorValve.invoke(CarbonContextCreatorValve.java:57)
>>>>> at
>>>>> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116)
>>>>> at
>>>>> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:421)
>>>>> at
>>>>> org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1074)
>>>>> at
>>>>> org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:611)
>>>>> at
>>>>> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1739)
>>>>> at
>>>>> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1698)
>>>>> at
>>>>> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
>>>>> at
>>>>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
>>>>> at
>>>>> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
>>>>> at java.lang.Thread.run(Thread.java:745)
>>>>>
>>>>>
>>>>> --
>>>>> *Charitha Goonetilleke*
>>>>> Software Engineer
>>>>> WSO2 Inc.; http://wso2.com
>>>>> lean.enterprise.middleware
>>>>>
>>>>> mobile: +94 77 751 3669 <%2B94777513669>
>>>>> Twitter:@CharithaWs <https://twitter.com/CharithaWs>, fb: charithag
>>>>> <https://www.facebook.com/charithag>, linkedin: charithag
>>>>> <http://www.linkedin.com/in/charithag>
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Hasintha Indrajee
>>>> Software Engineer
>>>> WSO2, Inc.
>>>> Mobile:+94 771892453
>>>>
>>>>
>>>
>>>
>>> --
>>> Regards,
>>>
>>>
>>> *Darshana Gunawardana*Senior Software Engineer
>>> WSO2 Inc.; http://wso2.com
>>>
>>> *E-mail: [email protected] <[email protected]>*
>>> *Mobile: +94718566859 <%2B94718566859>*Lean . Enterprise . Middleware
>>>
>>
>>
>>
>> --
>> *Charitha Goonetilleke*
>> Software Engineer
>> WSO2 Inc.; http://wso2.com
>> lean.enterprise.middleware
>>
>> mobile: +94 77 751 3669 <%2B94777513669>
>> Twitter:@CharithaWs <https://twitter.com/CharithaWs>, fb: charithag
>> <https://www.facebook.com/charithag>, linkedin: charithag
>> <http://www.linkedin.com/in/charithag>
>>
>> _______________________________________________
>> Dev mailing list
>> [email protected]
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
> Gayan Gunawardana
> Software Engineer; WSO2 Inc.; http://wso2.com/
> Email: [email protected]
> Mobile: +94 (71) 8020933
>



-- 
Regards,


*Darshana Gunawardana*Senior Software Engineer
WSO2 Inc.; http://wso2.com

*E-mail: [email protected] <[email protected]>*
*Mobile: +94718566859*Lean . Enterprise . Middleware
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to