Hi Devs, Tried $subject and its really cool, easy to set up and get working. Kudos to everyone to get that out...!!
I have checked the source and there are couple of things we can improve 1. Avoid using instance variables in the authentication to store any data since the authentication is a single. There are different context objects have different scopes, pick the correct context to store relevant data. 2. Having smsprovider.properties file to configure any additional data is correct. But if there is a need of such property file should be in the <IS_HOME>/repository/resources/ folder 3. It should have configurable the SMS text from the UI, rather from the property file. 4. We could comeup with a provisioning connector which do the number registering automatically, so it won't need to do manual update from external sms provider. Hope these suggestions improve the usability and functionality of the authenticator much more. Thanks, -- Regards, *Darshana Gunawardana*Senior Software Engineer WSO2 Inc.; http://wso2.com *E-mail: [email protected] <[email protected]>* *Mobile: +94718566859*Lean . Enterprise . Middleware
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
