+Elilmatha On Mon, Feb 15, 2016 at 6:56 PM, Darshana Gunawardana <[email protected]> wrote:
> Hi Devs, > > Tried $subject and its really cool, easy to set up and get working. Kudos > to everyone to get that out...!! > > I have checked the source and there are couple of things we can improve > > 1. Avoid using instance variables in the authentication to store any > data since the authentication is a single. There are different context > objects have different scopes, pick the correct context to store relevant > data. > 2. Having smsprovider.properties file to configure any additional data > is correct. But if there is a need of such property file should be in the > <IS_HOME>/repository/resources/ folder > 3. It should have configurable the SMS text from the UI, rather from > the property file. > 4. We could comeup with a provisioning connector which do the number > registering automatically, so it won't need to do manual update from > external sms provider. > > Hope these suggestions improve the usability and functionality of the > authenticator much more. > > Thanks, > > -- > Regards, > > > *Darshana Gunawardana*Senior Software Engineer > WSO2 Inc.; http://wso2.com > > *E-mail: [email protected] <[email protected]>* > *Mobile: +94718566859 <%2B94718566859>*Lean . Enterprise . Middleware > -- Best Regards, Malaka Silva Senior Tech Lead M: +94 777 219 791 Tel : 94 11 214 5345 Fax :94 11 2145300 Skype : malaka.sampath.silva LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77 Blog : http://mrmalakasilva.blogspot.com/ WSO2, Inc. lean . enterprise . middleware http://www.wso2.com/ http://www.wso2.com/about/team/malaka-silva/ <http://wso2.com/about/team/malaka-silva/> https://store.wso2.com/store/ Save a tree -Conserve nature & Save the world for your future. Print this email only if it is absolutely necessary.
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
