Yes, we need to avoid having common logging frameworks such as SLF4J in the classpath since it has a good possibility to lead to classloading issues for webapp developers .
Since slf4j could be used by multiple jars, it should be a separate shaded jar. I believe the *artifactId* should reflect that it is shaded. Otherwise, the jar name will be confusing. So, shall we use the name *slf4j-shaded*? On Tue, May 10, 2016 at 3:40 PM, Kishanthan Thangarajah <[email protected] > wrote: > +1, let's use the AS repo and at build time, which can get installed > during build time and this will also become part of release which will be > deployed onto nexus. > > Is the naming is correct? Shouldn't it be "shaded"? > +1. Thanks, KasunG > > On Tue, May 10, 2016 at 3:00 PM, Manoj Kumara <[email protected]> wrote: > >> Hi Dev's, >> >> During testing WSO2AS 6.0.0 we encounters $Subject error when SLF4j >> library available on the webapp libs directory as <AS_HOME>/lib also >> contain the same library to be used by libthrift library used during stat >> publishing. After analyzing the issue with the team realized that this >> occurred as Tomcat has a flat class path and multiple package versions >> cannot be used as in OSGI runtime. >> >> To resolve this as per the recommendation provided by KasunG we used '*Maven >> Shade Plugin* [1]' to shade package name (rename package structure and >> usages) as other open-source projects like Tomcat, Maven use similar >> patterns when using commonly used packages. >> >> As these shaded libraries required for AS distribution these libs need to >> be maintained inside product it self I suggest to maintain them as below >> with '*org.wso2.shade*' prefix on groupID. Thoughts ? >> >> <AS_HOME>/modules/*shade-libs* >> |--------- slf4j >> |--------- libthrift >> >> [1] https://maven.apache.org/plugins/maven-shade-plugin/ >> >> >> Regards, >> Manoj >> > > > > -- > *Kishanthan Thangarajah* > Associate Technical Lead, > Platform Technologies Team, > WSO2, Inc. > lean.enterprise.middleware > > Mobile - +94773426635 > Blog - *http://kishanthan.wordpress.com <http://kishanthan.wordpress.com>* > Twitter - *http://twitter.com/kishanthan <http://twitter.com/kishanthan>* > -- *Kasun Gajasinghe*Senior Software Engineer, WSO2 Inc. email: kasung AT spamfree wso2.com linked-in: http://lk.linkedin.com/in/gajasinghe blog: http://kasunbg.org
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
