Hi, Removed the call to retrieveApplication method.
Relevant PR can be found in[1]. [1]https://github.com/wso2/carbon-apimgt/pull/2495 On Thu, Jun 9, 2016 at 2:08 PM, Amila De Silva <[email protected]> wrote: > Hi, > > IMO DCR implementation should not depend on/use AMDefaultKeyManagerImpl > because; > 1. DCR offers a more basic functionality than AMDefaultKeyManagerImpl and > it should be KeyManager using DCR not the other way around. > 2. Using methods in apimgt bundles will create a dependancy on those > components, so before using DCR, users would have to install apimgt > features. > > So good if we can remove the call to retrieveApplication method. > > On Thu, Jun 9, 2016 at 10:16 AM, Kaveesha Perera <[email protected]> > wrote: > >> Hi, >> >> I worked on a issue in APIM of DCR that was described in [1].While >> working on it, observed that it has used APIM key manager interface based >> implementations for DCR related operations.After discussed with the team,I >> have modified the DCR endpoint implementation to calll directly the >> identity components based implementation, than accessing it via KeyManager >> implementation. >> >> The related PR can be found from here[2]. >> >> If any feedback, let me know. >> >> [1] [Architecture] Behavior of OAuth 2.0 Dynamic Client Registration >> [2] https://github.com/wso2/carbon-apimgt/pull/2495 >> >> >> Regards, >> -- >> Kaveesha Perera >> Intern - Software Engineering >> >> mobile: 0716130471 >> > > > > -- > *Amila De Silva* > > WSO2 Inc. > mobile :(+94) 775119302 > > -- Kaveesha Perera Intern - Software Engineering mobile: 0716130471
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
