+1 for having a common bundle. Also if we are to bootstrap opensaml in the bundle's activator, better to do it in a manner so that the server startup time will not get affected.
Regards, Omindu. On Sat, Jun 25, 2016 at 12:00 AM, Malithi Edirisinghe <[email protected]> wrote: > +1 > > We are also packing opensaml bundle with several features. I think it's > better if we can pack only from a common feature. > > Thanks, > Malithi. > > On Fri, Jun 24, 2016 at 11:16 PM, Farasath Ahamed <[email protected]> > wrote: > >> +1. >> >> Currently, we are bootstrapping the OpenSAML library once in each of the >> above-mentioned components once. Bootstrapping OpenSAML is a heavy >> operation and it is only required to be done once within a JVM. We can >> avoid bootstrapping more than once if we could do it within the activator >> of this proposed SAML common bundle. >> >> Thanks. >> >> Farasath Ahamed >> Software Engineer, >> WSO2 Inc.; http://wso2.com >> lean.enterprise.middleware >> >> >> Email: [email protected] >> Mobile: +94777603866 >> Blog: blog.farazath.com >> Twitter: @farazath619 <https://twitter.com/farazath619> >> >> On Fri, Jun 24, 2016 at 10:56 PM, Johann Nallathamby <[email protected]> >> wrote: >> >>> We have many bundles using SAML2. Inbound and outbound SAML2 SSO >>> authenticators, Carbon authenticators, SAML2 grant type in OAuth2, SAML2 >>> STS, Passive STS, entitlement, etc. Following items are seen duplicated in >>> these components. >>> >>> 1. Utility methods >>> 2. Constants >>> 3. Bootstrapping the OpenSAML library >>> >>> If we introduce a org.wso2.carbon.identity.saml.common bundle we can >>> have all these stuff in this single component and avoid all the problems. >>> This bundle can be a dependency to all the necessary components and packed >>> in all relevant features. >>> >>> Created JIRA: https://wso2.org/jira/browse/IDENTITY-4729 >>> >>> -- >>> Thanks & Regards, >>> >>> *Johann Dilantha Nallathamby* >>> Technical Lead & Product Lead of WSO2 Identity Server >>> Governance Technologies Team >>> WSO2, Inc. >>> lean.enterprise.middleware >>> >>> Mobile - *+94777776950* >>> Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>* >>> >> >> > > > -- > > *Malithi Edirisinghe* > Associate Technical Lead > WSO2 Inc. > > Mobile : +94 (0) 718176807 > [email protected] > -- Omindu Rathnaweera Software Engineer, WSO2 Inc. Mobile: +94 771 197 211
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
