Hi Osura,

On Tue, Jul 5, 2016 at 9:49 AM, Osura Rathnayake <[email protected]> wrote:

> Hi Akila,
>
> Please find more about tenantId here [1].
>
Seems the tenantId you are referring to a detail specific to Azure. Please
confirm. Since there is a tenancy concept in Carbon as well, shall we
re-name the variable and constant to something more meaningful (ex.: azure
TenantId for the variable name)?

>
> Regarding the last point, what I do is, I collect all the ip addresses and
> update the hazelcast config. in that case how can i get localMemberPort for
> each member since localMemberPOrt is defined in each member's axis2.xml.
> Also I observed that when the same localMemberPort is assigned to all the
> members, cluster discovery works fine but when different ports are assigned
> it doesn't work.
>
There should be a way to get this information (clustering port of members)
from the API, as we do for the IP addresses currently. If not, IMHO we can
keep the current implementation (where it assumes clustering port is 4000)
and document it clearly.

>
> Yes I'm still implementing the test cases and will update soon.
>
> [1]
> https://azure.microsoft.com/en-gb/documentation/articles/resource-group-create-service-principal-portal/
>
>
> thanks,
>
> On Mon, Jul 4, 2016 at 9:41 PM, Akila Ravihansa Perera <[email protected]
> > wrote:
>
>> Hi Osura,
>>
>> I'm still not clear on tenantId. Perhaps you can explain in detail during
>> the code review meeting. Regarding the last point, yes it should be
>> localMemberPort. Sorry, it was a typo.
>>
>> One more thing, I noticed that test cases are empty [1]. Are you still
>> working on implementing those?
>>
>> [1]
>> https://github.com/osuran/azure-membership-scheme/blob/master/src/test/java/org/wso2/carbon/clustering/azure/AppTest.java
>>
>> Thanks.
>>
>
>
>
> --
> Regards,
> Osura Rathnayake
>



-- 
Thanks and Regards,

Isuru H.
+94 716 358 048* <http://wso2.com/>*
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to