Hi Akila, Please refer to the screenshots that I have attached. When I updated localMemberPort to 4200, I can see it being reflected in logs when members are joining. So should I still make modifications in the code?
.gitignore was added. okay I will write test cases in testNG and update thanks, On Wed, Jul 6, 2016 at 9:06 AM, Akila Ravihansa Perera <[email protected]> wrote: > Hi, > > On Tue, Jul 5, 2016 at 11:38 AM, Osura Rathnayake <[email protected]> > wrote: > >> Hi Akila, >> >> Please check the modified code. It now takes the value which is specified >> as localMemberPort in axis2.xml. >> > > I still don't see any change to the logic of how member address is > calculated. Can you double check? > > Please make sure "target/**" directories are ignored from .gitignore. > These shouldn't be in the repo [1]. You might also need to ignore any IDE > specific files. Have a look at .gitignore in Kubernetes artifacts [2]. > > I see that you have committed some test cases based on JUnit. Please note > that as a platform we are moving to testng framework so better to use that. > @Imesh, Isuru: Please correct me if I'm wrong. > > Shall we get a repo created under wso2-incubator for this? > > [1] https://github.com/osuran/azure-membership-scheme/tree/master/target > [2] https://github.com/wso2/kubernetes-artifacts/blob/master/.gitignore > > Thanks. > -- > Akila Ravihansa Perera > WSO2 Inc.; http://wso2.com/ > > Blog: http://ravihansa3000.blogspot.com > -- Regards, Osura Rathnayake
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
