Hi Isuru, Can you please resend the PR with above discussed changes.
Thanks, Jayanga. *Jayanga Dissanayake* Associate Technical Lead WSO2 Inc. - http://wso2.com/ lean . enterprise . middleware email: [email protected] mobile: +94772207259 <http://wso2.com/signature> On Wed, Aug 10, 2016 at 12:46 PM, Isuru Perera <[email protected]> wrote: > Hi, > > On Wed, Aug 10, 2016 at 12:35 PM, KasunG Gajasinghe <[email protected]> > wrote: > >> >> >> >> On Wed, Aug 10, 2016 at 11:45 AM, Isuru Perera <[email protected]> wrote: >> >>> Hi, >>> >>> I also don't keep all sources locally. For a Maven Dependency, I expect >>> the sources jar in Maven Repository. >>> >>> Even in Carbon Kernel 4.x, I don't see source jars [1]. In Carbon 5.x, I >>> see the sources [2]. >>> >>> >> That was because we have defined an older version of the >> maven-source-plugin in 4.4.7. If we didn't explicitly mention this, then >> there the version will be inherited from the already defined >> maven-source-plugin in wso2 parent pom. That's a separate issue we need to >> fix. @*Lakshman*, please remove the plugin definition from kernel parent >> for the next release. >> >> >> >>> My opinion is that we should have source jars always. >>> >> >> You already have the sources locally! >> > I mean other dependencies. I don't want to checkout those sources locally. > >> >> >>> >>> It's same for Java Docs. We must make sure Java Docs is written properly >>> and there are no warnings. Having the java doc plugin helps us to fix any >>> issues with docs during the development time, rather than waiting to fix >>> such issues whenever there is a release. >>> >> >> If has issues, then checkstyle complains to some extent. If you want to >> verify javadocs, then, you can run maven-source-plugin:jar-no-fork goal >> and generate the javadocs. There is no need to run it everytime. >> > If you and others don't think that there is no need to have those plugins, > please remove it from the parent pom. :) > > Please merge other changes. > >> Even for the compiler plugin, we have a incremental build plugin which >> skips building already built modules. >> > > >> >> Thanks, >> KasunG >> >> >>> Anyway, please merge other changes and make sure all plugins are up to >>> date in Carbon Parent. As I mentioned, I didn't update all. >>> >>> Thanks! >>> >>> Best Regards, >>> >>> [1] https://maven.wso2.org/nexus/content/repositories/releases/o >>> rg/wso2/carbon/org.wso2.carbon.core/4.4.7/ >>> [2] https://maven.wso2.org/nexus/content/repositories/releases/o >>> rg/wso2/carbon/org.wso2.carbon.core/5.1.0/ >>> >>> On Wed, Aug 10, 2016 at 11:28 AM, Isuru Perera <[email protected]> wrote: >>> >>>> Hi Kasun, >>>> >>>> On Wed, Aug 10, 2016 at 9:54 AM, KasunG Gajasinghe <[email protected]> >>>> wrote: >>>> >>>>> Hi Isuru, >>>>> >>>>> Javadoc and source generation happens when you use the maven release >>>>> plugin. We are already doing it. [1] >>>>> >>>> I don't see the source jar in the location you mentioned. >>>> >>>>> That is the only place we need these two plugins as I understand. When >>>>> doing a build locally, you don't really need sources/javadoc jars because >>>>> you already have the source code. >>>>> >>>>> [1] https://maven.wso2.org/nexus/content/repositories/releas >>>>> es/org/wso2/carbon/org.wso2.carbon.ndatasource.core/4.4.7/ >>>>> >>>>> Thanks, >>>>> KasunG >>>>> >>>>> On Tue, Aug 9, 2016 at 7:24 PM, Isuru Perera <[email protected]> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> On Tue, Aug 9, 2016 at 3:10 PM, Jayanga Dissanayake <[email protected] >>>>>> > wrote: >>>>>> >>>>>>> Hi Isuru, >>>>>>> >>>>>>> It seems to be the culprit. I removed the jacoco plugin from >>>>>>> carbon-kernel/parent/pom.xml and it builds. >>>>>>> >>>>>>> One other concern is, in this PR, you have moved the doc and source >>>>>>> plugins into plugin section, which cause it to run always. But we >>>>>>> usually >>>>>>> don't want src and docs to be generated at each build. Could you please >>>>>>> explain why those plugins were moved into plugin section. >>>>>>> >>>>>> I added java doc and source plugins to parent pom as we need to have >>>>>> sources jars and java docs every time we build the source. >>>>>> >>>>>> If you look at our previous releases based on Carbon 4.x, there are >>>>>> no source jars for most of the components. Without having sources jars, >>>>>> it >>>>>> is very difficult to debug as well. >>>>>> >>>>>> Even though, we expected our developers to release the sources jars >>>>>> during release time, we can see that it's not happening most of the time. >>>>>> >>>>>> Java Doc generation is also very important and Java Doc Plugin shows >>>>>> warnings if there are any issues with our Java Docs. It's easy to fix >>>>>> such >>>>>> warnings before the release. >>>>>> >>>>>> If the build time is the main concern for local builds, we can >>>>>> disable Java doc plugin as it takes some time. The source plugin doesn't >>>>>> take much time. >>>>>> >>>>>> For local builds, we can skip java docs using the parameter: >>>>>> "-Dmaven.javadoc.skip=true". >>>>>> >>>>>> I think having these plugins in parent pom is very important. >>>>>> >>>>>>> >>>>>>> Thanks, >>>>>>> Jayanga. >>>>>>> >>>>>>> Thanks, >>>>>>> Jayanga. >>>>>>> >>>>>>> *Jayanga Dissanayake* >>>>>>> Associate Technical Lead >>>>>>> WSO2 Inc. - http://wso2.com/ >>>>>>> lean . enterprise . middleware >>>>>>> email: [email protected] >>>>>>> mobile: +94772207259 >>>>>>> <http://wso2.com/signature> >>>>>>> >>>>>>> On Tue, Aug 9, 2016 at 2:34 PM, Isuru Perera <[email protected]> >>>>>>> wrote: >>>>>>> >>>>>>>> Did you remove existing Jacoco plugin in Carbon Kernel? >>>>>>>> >>>>>>>> Isuru Perera >>>>>>>> >>>>>>>> On 9 Aug 2016 2:29 p.m., "Jayanga Dissanayake" <[email protected]> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Hi Isuru, >>>>>>>>> >>>>>>>>> When I try to build the carbon kernel with new parent pom with >>>>>>>>> your updates, the following error happens. >>>>>>>>> It seems to be an issue in jacoco plugin, any idea? >>>>>>>>> >>>>>>>>> [ERROR] Failed to execute goal >>>>>>>>> org.jacoco:jacoco-maven-plugin:0.7.5.201505241946:report >>>>>>>>> (post-unit-test) on project org.wso2.carbon.launcher: An error has >>>>>>>>> occurred >>>>>>>>> in JaCoCo Test report generation. Error while creating report: Error >>>>>>>>> while >>>>>>>>> analyzing class /tmp/1/carbon-kernel/launcher/ >>>>>>>>> target/classes/org/wso2/carbon/launcher/CarbonServer.class. Class >>>>>>>>> org/wso2/carbon/launcher/CarbonServer is already instrumented. -> >>>>>>>>> [Help 1] >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Jayanga. >>>>>>>>> >>>>>>>>> *Jayanga Dissanayake* >>>>>>>>> Associate Technical Lead >>>>>>>>> WSO2 Inc. - http://wso2.com/ >>>>>>>>> lean . enterprise . middleware >>>>>>>>> email: [email protected] >>>>>>>>> mobile: +94772207259 >>>>>>>>> <http://wso2.com/signature> >>>>>>>>> >>>>>>>>> On Tue, Aug 9, 2016 at 12:24 PM, Isuru Perera <[email protected]> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Hi Jayanga, >>>>>>>>>> >>>>>>>>>> I didn't update maven bundle plugin. Could you please check on >>>>>>>>>> that too? >>>>>>>>>> >>>>>>>>>> Please use following command to check plugin updates. >>>>>>>>>> >>>>>>>>>> mvn versions:display-plugin-updates >>>>>>>>>> >>>>>>>>>> Thanks! >>>>>>>>>> >>>>>>>>>> On Tue, Aug 9, 2016 at 11:39 AM, Kishanthan Thangarajah < >>>>>>>>>> [email protected]> wrote: >>>>>>>>>> >>>>>>>>>>> Hi Jayanga, >>>>>>>>>>> >>>>>>>>>>> Let's merge this and do a release along with kernel 5.2.0. >>>>>>>>>>> >>>>>>>>>>> On Wed, Jul 27, 2016 at 3:44 PM, Isuru Perera <[email protected]> >>>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi, >>>>>>>>>>>> >>>>>>>>>>>> Could you please review the PR in [1]. >>>>>>>>>>>> >>>>>>>>>>>> I also noticed that carbon-parent version 5 is released [2], >>>>>>>>>>>> but the master branch still has 5-SNAPSHOT [3]. >>>>>>>>>>>> >>>>>>>>>>>> [1] https://wso2.org/jira/browse/CPARENT-6 >>>>>>>>>>>> [2] https://github.com/wso2/carbon >>>>>>>>>>>> -parent/releases/tag/carbon-parent-5 >>>>>>>>>>>> [3] https://github.com/wso2/carbon >>>>>>>>>>>> -parent/blob/master/pom.xml#L22 >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> Isuru Perera >>>>>>>>>>>> Associate Technical Lead | WSO2, Inc. | http://wso2.com/ >>>>>>>>>>>> Lean . Enterprise . Middleware >>>>>>>>>>>> >>>>>>>>>>>> about.me/chrishantha >>>>>>>>>>>> Contact: +IsuruPereraWSO2 >>>>>>>>>>>> <https://www.google.com/+IsuruPereraWSO2/about> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> *Kishanthan Thangarajah* >>>>>>>>>>> Technical Lead, >>>>>>>>>>> Platform Technologies Team, >>>>>>>>>>> WSO2, Inc. >>>>>>>>>>> lean.enterprise.middleware >>>>>>>>>>> >>>>>>>>>>> Mobile - +94773426635 >>>>>>>>>>> Blog - *http://kishanthan.wordpress.com >>>>>>>>>>> <http://kishanthan.wordpress.com>* >>>>>>>>>>> Twitter - *http://twitter.com/kishanthan >>>>>>>>>>> <http://twitter.com/kishanthan>* >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Isuru Perera >>>>>>>>>> Associate Technical Lead | WSO2, Inc. | http://wso2.com/ >>>>>>>>>> Lean . Enterprise . Middleware >>>>>>>>>> >>>>>>>>>> about.me/chrishantha >>>>>>>>>> Contact: +IsuruPereraWSO2 >>>>>>>>>> <https://www.google.com/+IsuruPereraWSO2/about> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Isuru Perera >>>>>> Associate Technical Lead | WSO2, Inc. | http://wso2.com/ >>>>>> Lean . Enterprise . Middleware >>>>>> >>>>>> about.me/chrishantha >>>>>> Contact: +IsuruPereraWSO2 >>>>>> <https://www.google.com/+IsuruPereraWSO2/about> >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> >>>>> *Kasun Gajasinghe*Associate Technical Lead, WSO2 Inc. >>>>> email: kasung AT spamfree wso2.com >>>>> linked-in: http://lk.linkedin.com/in/gajasinghe >>>>> blog: http://kasunbg.org >>>>> >>>>> >>>>> >>>> >>>> >>>> >>>> -- >>>> Isuru Perera >>>> Associate Technical Lead | WSO2, Inc. | http://wso2.com/ >>>> Lean . Enterprise . Middleware >>>> >>>> about.me/chrishantha >>>> Contact: +IsuruPereraWSO2 >>>> <https://www.google.com/+IsuruPereraWSO2/about> >>>> >>> >>> >>> >>> -- >>> Isuru Perera >>> Associate Technical Lead | WSO2, Inc. | http://wso2.com/ >>> Lean . Enterprise . Middleware >>> >>> about.me/chrishantha >>> Contact: +IsuruPereraWSO2 >>> <https://www.google.com/+IsuruPereraWSO2/about> >>> >> >> >> >> -- >> >> *Kasun Gajasinghe*Associate Technical Lead, WSO2 Inc. >> email: kasung AT spamfree wso2.com >> linked-in: http://lk.linkedin.com/in/gajasinghe >> blog: http://kasunbg.org >> >> >> > > > > -- > Isuru Perera > Associate Technical Lead | WSO2, Inc. | http://wso2.com/ > Lean . Enterprise . Middleware > > about.me/chrishantha > Contact: +IsuruPereraWSO2 <https://www.google.com/+IsuruPereraWSO2/about> >
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
