Hi Thusitha, Please make sure to merge Spring profile related improvements (both property file and YAML files based) in to new RC.
Thanks ! On Tue, Oct 25, 2016 at 6:39 PM, Afkham Azeez <[email protected]> wrote: > We are calling off the vote on the current RC because of issues. So we may > be able to merge this. > > On Tue, Oct 25, 2016 at 5:50 PM, Sanjeewa Malalgoda <[email protected]> > wrote: > >> Added comment on pull request. Please consider this for next release. >> >> Thanks, >> sanjeewa. >> >> On Mon, Oct 24, 2016 at 6:32 PM, Sanjeewa Malalgoda <[email protected]> >> wrote: >> >>> Yes this kind of solution will work for the moment. Thanks all for your >>> inputs. >>> >>> Thanks, >>> sanjeewa. >>> >>> On Mon, Oct 24, 2016 at 6:22 PM, Lakshan Gamage <[email protected]> >>> wrote: >>> >>>> Hi all, >>>> >>>> In the solution I provided with my PR [1], this was done by overloading >>>> deploy method in MicroservicesRunner. But I also think it would be better >>>> if we can support @ApplicationPath annotation in the future. >>>> >>>> [1] - https://github.com/wso2/msf4j/pull/287 >>>> >>>> On Mon, Oct 24, 2016 at 5:49 PM, Thusitha Thilina Dayaratne < >>>> [email protected]> wrote: >>>> >>>>> Hi Sanjeewa, >>>>> >>>>> We had a similar request a few weeks ago[1] (But at compile time). But >>>>> we decided not to add this as a feature since users can append the path >>>>> when defining the class @Path. >>>>> >>>>>> >>>>>> If we take this base context to code level things will work. But its >>>>>> not a clean solution IMO. So at the time we start service or some >>>>>> configuration file should allow to add root context to API easily. Can we >>>>>> do something like this? >>>>> >>>>> IMHO providing the base path as a config value is a good approach. >>>>> We might need to support @ApplicationPath in future release. >>>>> >>>>> [1] - Dev Mail thread: "[Dev] Setting the Application Base URI in msf4j >>>>> " >>>>> >>>>> Thanks >>>>> Thusitha >>>>> >>>>> On Mon, Oct 24, 2016 at 5:41 PM, Sanjeewa Malalgoda <[email protected] >>>>> > wrote: >>>>> >>>>>> Hi Azeez, All, >>>>>> When we are implementing APIs for API Management operations we need >>>>>> to run APIs with different contexts. As examples /apis for publisher can >>>>>> be >>>>>> different from store API. So far what we have done is adding base context >>>>>> per each API. But that is not a part of API definition. Sometimes that >>>>>> helped users to run their APIs with different contexts. >>>>>> >>>>>> If we take this base context to code level things will work. But its >>>>>> not a clean solution IMO. So at the time we start service or some >>>>>> configuration file should allow to add root context to API easily. Can we >>>>>> do something like this? >>>>>> >>>>>> Thanks, >>>>>> sanjeewa. >>>>>> >>>>>> -- >>>>>> >>>>>> *Sanjeewa Malalgoda* >>>>>> WSO2 Inc. >>>>>> Mobile : +94713068779 >>>>>> >>>>>> <http://sanjeewamalalgoda.blogspot.com/>blog >>>>>> :http://sanjeewamalalgoda.blogspot.com/ >>>>>> <http://sanjeewamalalgoda.blogspot.com/> >>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Thusitha Dayaratne >>>>> Software Engineer >>>>> WSO2 Inc. - lean . enterprise . middleware | wso2.com >>>>> >>>>> Mobile +94712756809 >>>>> Blog alokayasoya.blogspot.com >>>>> About http://about.me/thusithathilina >>>>> <http://wso2.com/signature> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Dev mailing list >>>>> [email protected] >>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>> >>>>> >>>> >>>> >>>> -- >>>> >>>> *Lakshan Gamage*Software Engineering Intern >>>> WSO2 Inc.; http://wso2.com >>>> >>>> *E-mail: [email protected] <[email protected]>* >>>> *Mobile: +94773472649 <%2B94773472649>*Lean . Enterprise . Middleware >>>> <http://wso2.com/signature> >>>> >>> >>> >>> >>> -- >>> >>> *Sanjeewa Malalgoda* >>> WSO2 Inc. >>> Mobile : +94713068779 >>> >>> <http://sanjeewamalalgoda.blogspot.com/>blog >>> :http://sanjeewamalalgoda.blogspot.com/ >>> <http://sanjeewamalalgoda.blogspot.com/> >>> >>> >>> >> >> >> -- >> >> *Sanjeewa Malalgoda* >> WSO2 Inc. >> Mobile : +94713068779 >> >> <http://sanjeewamalalgoda.blogspot.com/>blog >> :http://sanjeewamalalgoda.blogspot.com/ >> <http://sanjeewamalalgoda.blogspot.com/> >> >> >> >> _______________________________________________ >> Dev mailing list >> [email protected] >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > *Afkham Azeez* > Director of Architecture; WSO2, Inc.; http://wso2.com > Member; Apache Software Foundation; http://www.apache.org/ > * <http://www.apache.org/>* > *email: **[email protected]* <[email protected]> > * cell: +94 77 3320919 <%2B94%2077%203320919>blog: * > *http://blog.afkham.org* <http://blog.afkham.org> > *twitter: **http://twitter.com/afkham_azeez* > <http://twitter.com/afkham_azeez> > *linked-in: **http://lk.linkedin.com/in/afkhamazeez > <http://lk.linkedin.com/in/afkhamazeez>* > > *Lean . Enterprise . Middleware* > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- Sagara Gunathunga Associate Director / Architect; WSO2, Inc.; http://wso2.com V.P Apache Web Services; http://ws.apache.org/ Linkedin; http://www.linkedin.com/in/ssagara Blog ; http://ssagara.blogspot.com
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
