Hi All, IMO, there is no point having a separate file just to print the kernel version. I think we could derive the version from carbon.core bundle if we need the -version option.
The placeholders in the kernel-version.txt file are updated with the corresponding values given in the filter.properties file at compile time. Hence all the product teams will have to provide valid values for the placeholders in kernel-version.txt on the product specific filter.properties file. Otherwise, the file kernel-version.txt will not get updated properly. One other concern is, with the C4 based patch model we packed a separate *.txt file with the carbon version and patch number. But with C5 and its update model (yet to be discussed), I think we need to support "-version" without having a separate file. Thanks, Jayanga. *Jayanga Dissanayake* Associate Technical Lead WSO2 Inc. - http://wso2.com/ lean . enterprise . middleware email: [email protected] mobile: +94772207259 <http://wso2.com/signature> On Mon, Jan 9, 2017 at 11:22 AM, Dilan Udara Ariyaratne <[email protected]> wrote: > Hi Folks, > > I am referring to carbon-kernel git issue 1239 - > https://github.com/wso2/carbon-kernel/issues/1239 > > When I looked into the usage of this file, the only usage found is getting > the kernel version from that file and > printing it on the console when command ./carbon.sh version is invoked. > > AFAIU, there are two concerns that we need to consider here. > > [1] Do we really need this version option with ./carbon.sh command ? > My opinion is that it's a nice to have feature with respect to user > experience. > Nowadays, many of the softwares support this handy feature with > -version option preceded by some alias to represent the corresponding > software. > For ex: > Java and mvn have following outputs for -version option > > command : > java -version > output : > Java(TM) SE Runtime Environment (build 1.8.0_102-b14) > Java HotSpot(TM) 64-Bit Server VM (build 25.102-b14, mixed mode) > > command : > mvn -version > output : > Apache Maven 3.3.9 > Maven home: /usr/share/maven > Java version: 1.8.0_102, vendor: Oracle Corporation > Java home: /home/abc/Programs/Java/jdk1.8.0_102/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "4.4.0-57-generic", arch: "amd64", family: > "unix" > > [2] If we are supporting this option with ./carbon.sh, what is the ideal > way to obtain any version information ? > Currently, we are getting the version value of carbon kernel with the > aforementioned kernel-version.txt file which resides in <CARBON_HOME>/bin. > For ex: > > command : > ./carbon.sh version > output : > WSO2 Carbon Kernel v5.2.0-SNAPSHOT > > So, the question would be that "Is this the ideal way of doing this" > or will there be any other better alternatives ? > > Please share your valuable thoughts on this. > > Cheers, > Dilan. > > *Dilan U. Ariyaratne* > Senior Software Engineer > WSO2 Inc. <http://wso2.com/> > Mobile: +94766405580 <%2B94766405580> > lean . enterprise . middleware > > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > >
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
