Thanks Praminda. Merged the changes.
Thanks Chamalee On Tue, Nov 28, 2017 at 12:28 PM, Praminda Jayawardana <[email protected]> wrote: > Approved > > On Tue, Nov 28, 2017 at 12:14 PM, Chamalee De Silva <[email protected]> > wrote: > >> Hi, >> It seems we have added this up to C5 API definition as well though it is >> not used. >> Removed the CONTROLLED visibility from API definition of C5 with PR [1]. >> Please review and approve. >> >> >> [1] https://github.com/wso2/carbon-apimgt/pull/4767 >> >> >> On Mon, Nov 27, 2017 at 6:46 PM, Sanjeewa Malalgoda <[email protected]> >> wrote: >> >>> Sometimes back we had this feature with API Manager and later we removed >>> that. With that we can select set of tenants we need to expose our API. >>> I do not think we have usages of this feature. It was there in APIM >>> 1.4.0 as remember and removed in 1.6.0 or later version. >>> >>> [1]https://docs.wso2.com/display/AM140/API+Visibility >>> >>> Thanks, >>> sanjeewa. >>> >>> On Mon, Nov 27, 2017 at 5:34 PM, Chamalee De Silva <[email protected]> >>> wrote: >>> >>>> Hi team, >>>> >>>> In our visibility model of API in C4, we have following three types of >>>> visibility which are documented. >>>> >>>> >>>> - Public: >>>> - >>>> >>>> Restricted by Roles (restrcted) >>>> - >>>> >>>> Visible to my domain: (private) >>>> >>>> >>>> But when checking with the code (I am refering to the C4 code), I could >>>> found that there is another visibility level called *controlled.* >>>> >>>> This *controlled* visibility level goes with a list of >>>> "visibleTenants", but could not find any usage of it. >>>> When adding or updating an API as well as when retrieving the API this >>>> "visibleTenants" is added if available [1]. >>>> >>>> Can anyone point out what is the use of this controlled visibility >>>> level and is there a way to control visibility for specific tenants through >>>> this without UI ? >>>> >>>> >>>> When it comes to subscription availability, there is a >>>> separate property "subscriptionTenants" for the API, so this >>>> "visibleTenants" is not related to that. >>>> >>>> Any reason for keeping this *controlled* visibility level ? >>>> Even in the REST API we have added this though it seems not used. >>>> >>>> >>>> >>>> >>>> [1] https://github.com/wso2/carbon-apimgt/blob/6.1.x/components/ >>>> apimgt/org.wso2.carbon.apimgt.hostobjects/src/main/java/org/ >>>> wso2/carbon/apimgt/hostobjects/APIProviderHostObject.java#L1737 >>>> >>>> >>>> >>>> >>>> -- >>>> Thanks & Regards, >>>> >>>> *Chamalee De Silva* >>>> Software Engineer >>>> *WS**O2* Inc. :http://wso2.com/ >>>> >>>> Office :- *+94 11 2145345 <%2B94%2011%202145345>* >>>> mobile :- *+94 7 <%2B94%2077%202782039>1 4315942* >>>> >>>> >>> >>> >>> -- >>> >>> *Sanjeewa Malalgoda* >>> WSO2 Inc. >>> Mobile : +94713068779 <+94%2071%20306%208779> >>> >>> <http://sanjeewamalalgoda.blogspot.com/>blog >>> :http://sanjeewamalalgoda.blogspot.com/ >>> <http://sanjeewamalalgoda.blogspot.com/> >>> >>> >>> >> >> >> -- >> Thanks & Regards, >> >> *Chamalee De Silva* >> Software Engineer >> *WS**O2* Inc. :http://wso2.com/ >> >> Office :- *+94 11 2145345 <%2B94%2011%202145345>* >> mobile :- *+94 7 <%2B94%2077%202782039>1 4315942* >> >> > > > -- > > *Praminda Jayawardana* > Software Engineer > WSO2 Inc.; http://wso2.com > Mobile : +94 (0) 716 590918 <+94%2071%20659%200918> > -- Thanks & Regards, *Chamalee De Silva* Software Engineer *WS**O2* Inc. :http://wso2.com/ Office :- *+94 11 2145345 <%2B94%2011%202145345>* mobile :- *+94 7 <%2B94%2077%202782039>1 4315942*
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
