I'm concerned thinking that whether there is a real is-a relationship here.
The parent class name is AbstractSecuredEntityManager which gives the feeling that this is a parent class which provides some security functionality. (e.g. secured invocations) But it has a method called initUserRolesCache which is not relevant. On Fri, Jan 19, 2018 at 6:07 PM, Jayanga Kaushalya <[email protected]> wrote: > Hi all, > > We have identified there are few common methods(callSecure(), > initUserRolesCache(), etc..) in $subject mentioned classes in UserCore[1]. > So we have decided to create a common parent(AbstractSecuredEntityManager) > for those classes to minimize the code duplication. > > Please provide your thoughts. > > [1] https://github.com/wso2/carbon-kernel/tree/4.4.x/core/ > org.wso2.carbon.user.core > > Thanks! > > *Jayanga Kaushalya* > Senior Software Engineer > Mobile: +94777860160 <+94%2077%20786%200160> > WSO2 Inc. | http://wso2.com > lean.enterprise.middleware > > > -- *Best Regards* *Rushmin Fernando* *Technical Lead* WSO2 Inc. <http://wso2.com/> - Lean . Enterprise . Middleware mobile : +94775615183
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
