I think the bottom line is that there is no good reason to have two repositories for the same project component.
The best solution is to bring all of xalan-test into xalan-java and be done with it. Easy for me to say of course ;-) I am looking for the BCEL commit that caused the regression ATM... Gary On Sat, Nov 12, 2022, 13:27 Joseph Kesselman <kesh...@alum.mit.edu> wrote: > Apologies if I am misunderstanding the issue.... > > Ideally, regression tests should be considered part of the build process, > though we often skip them. Compiling them is itself a regression test > against unexpected api changes. > > So my own preference would still be to have them be part of the same Git > package, but build them into a separate jar file; they would be run, but > not shipped, as part of doing a production build. Putting them in a > separate package wouldn't seem to have any advantages. > > -- > /_ Joe Kesselman (he/him/his) > -/ _) My Alexa skill for New Music/New Sounds fans: > / https://www.amazon.com/dp/B09WJ3H657/ > > () Plaintext Ribbon Campaign > /\ Stamp out HTML mail! > ------------------------------ > *From:* Mukul Gandhi <muk...@apache.org> > *Sent:* Saturday, November 12, 2022 11:44:54 AM > *To:* dev@xalan.apache.org <dev@xalan.apache.org> > *Subject:* Re: [request to review, and vote] XalanJ 2.7.3 release > candidate RC5 > > Hi Gary, > > On Mon, Oct 31, 2022 at 8:39 PM Gary D. Gregory <ggreg...@apache.org> > wrote: > > > > Hi Mukul, > > > > It does not feel like a good idea to exclude tests from the src > zip/tars. This is most likely due to our use of Ant; this would not be an > issue with Maven obviously, since it packages tests in a test jar and in > sources, at least in the way we use Maven in other projects (Commons for > example). Since we deliver sources, it seems reasonable to deliver tests to > support the use case where a user or Linux distro wants to build from > scratch and use git: > > - Download src zip or tar > > - Possibly edit sources for reason X or to fix a bug > > - Test and Build > > - "Release" internally to the users dist system (or not) > > Today we've made, few improvements to xalan-java (branch > xalan-j_2_7_1_maint) and xalan-test (branch master) repos build files. > > Now, when producing xalan-j_2_7_3-src.zip and xalan-j_2_7_3-src.tar.gz > files (for the XalanJ release, 2.7.3) using XalanJ dist target > fulldist, we include the test's java codebase jar and their associated > meta-data as well within these zip and tar.gz files. > > As of now, from the user's view point, when they'll unzip for example > xalan-j_2_7_3-src.zip, and try to run the tests with smoketest or > smoketest.xsltc ant targets using buiild.xml from > xalan-j_2_7_3-src.zip, the tests would actually not run, unless the > user does git clone of XalanJ's xalan-test repos (the master branch). > Do you think, this shall be fine? > > Or, you'd like the user, to be able to run XalanJ tests without having > (i.e, cloning) copy of XalanJ's xalan-test repos (I believe, this > should be technically possible to do, by making certain changes to > xalan-j_2_7_3-src.zip/xalan-j_2_7_3-src.tar.gz build file while > producing these via fulldist build target, since we now also have > tests jar and their meta-data within the src/tar distributables)? > > > -- > Regards, > Mukul Gandhi > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org > For additional commands, e-mail: dev-h...@xalan.apache.org > >
