Hi Mukul and anyone that wants to help: I think we need to establish a baseline for testing because it is not clear to me that I am getting valid build and test results with what's in the repos now.
I build xalan-java's xalan-j_2_7_1_maint branch with 'ant fulldist' (the bat files don't work for me and it seems simpler to use Ant directly). I copy the jars per https://gitbox.apache.org/repos/asf?p=xalan-java.git;a=blob_plain;f=README;hb=refs/heads/xalan-j_2_7_1_maint to JARDIR=C:\tmp\xalanj-bcel660. Then I build xalan-test's master branch with 'ant jar' and copy the jar and run 'ant smoketest.xsltc' which gives me: run.xalantest: scan: [java] ResultScanner error on: results-accept.xsltc [java] java.io.FileNotFoundException: ResultScanner: resultDir results-accept.xsltc does not exist! [java] at org.apache.qetest.xsl.ResultScanner.scanResults(ResultScanner.java:67) [java] at org.apache.qetest.xsl.ResultScanner.main(ResultScanner.java:326) scan: [java] ResultScanner of smoketest.xsltc complete in: smoketest.xsltc/ResultReport.html smoketest.xsltc-notpass: smoketest.xsltc-pass: [echo] [minitest] CONGRATULATIONS! The Smoketest passed! [echo] [minitest] Details are in smoketest.xsltc/results-conf.xml, smoketest.xsltc/results-accept.xml Which seems broken due to the "java.io.FileNotFoundException: ResultScanner: resultDir results-accept.xsltc does not exist!" That's a broken build right? Gary On 2022/11/12 16:44:54 Mukul Gandhi wrote: > Hi Gary, > > On Mon, Oct 31, 2022 at 8:39 PM Gary D. Gregory <ggreg...@apache.org> wrote: > > > > Hi Mukul, > > > > It does not feel like a good idea to exclude tests from the src zip/tars. > > This is most likely due to our use of Ant; this would not be an issue with > > Maven obviously, since it packages tests in a test jar and in sources, at > > least in the way we use Maven in other projects (Commons for example). > > Since we deliver sources, it seems reasonable to deliver tests to support > > the use case where a user or Linux distro wants to build from scratch and > > use git: > > - Download src zip or tar > > - Possibly edit sources for reason X or to fix a bug > > - Test and Build > > - "Release" internally to the users dist system (or not) > > Today we've made, few improvements to xalan-java (branch > xalan-j_2_7_1_maint) and xalan-test (branch master) repos build files. > > Now, when producing xalan-j_2_7_3-src.zip and xalan-j_2_7_3-src.tar.gz > files (for the XalanJ release, 2.7.3) using XalanJ dist target > fulldist, we include the test's java codebase jar and their associated > meta-data as well within these zip and tar.gz files. > > As of now, from the user's view point, when they'll unzip for example > xalan-j_2_7_3-src.zip, and try to run the tests with smoketest or > smoketest.xsltc ant targets using buiild.xml from > xalan-j_2_7_3-src.zip, the tests would actually not run, unless the > user does git clone of XalanJ's xalan-test repos (the master branch). > Do you think, this shall be fine? > > Or, you'd like the user, to be able to run XalanJ tests without having > (i.e, cloning) copy of XalanJ's xalan-test repos (I believe, this > should be technically possible to do, by making certain changes to > xalan-j_2_7_3-src.zip/xalan-j_2_7_3-src.tar.gz build file while > producing these via fulldist build target, since we now also have > tests jar and their meta-data within the src/tar distributables)? > > > -- > Regards, > Mukul Gandhi > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org > For additional commands, e-mail: dev-h...@xalan.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
