I am still seeing ./build.sh conf.xsltc on Linux reporting failure on
multiple tests (whitespace35, output63, idkey49, idkey31, math111),
though the overall conf.xsltc test reports passing -- so either these
were accepted errors or something about the test driver isn't quite
right (or both). I haven't looked at them in detail yet, checked whether
they are regressions from the previous version, or checked whether the
same tests fail under Windows. Technically since conf.xsltc reports
success we can defend this as a clean release candidate, but I'd be
happier if we were sure of their status (and had issues open on them).
COSMETICS:
I'd like to propose:
delete from xalan-test:
java/src/org/apache/qetest/rwapi/XPathASTTestlet.java
delete from xalan-test:
java/src/org/apache/qetest/xsltc/TimeXSLTCDom.java
These both appear to refer to classes from the pre-Xalan (Sun)
implementation of the XSLTC compiler; they do not compile now, and are
not run during our normal tests. I see no reason to retain them, and
they do cause complaints from Eclipse.
(The other class that may not compile right now is XTWrapper -- but
that's OK, that class exists to let our test suite be run against James
Clark's XT processor, and for obvious reasons won't build without XT on
the classpath. Unless XT itself has been discontinued, we should retain
this as a courtesy and to illustrate how our tests can be reused.)
I'd also like to propose that my change for
SystemIDResolverAPITest.testCase1() be reworked one more time, to use
the Java library rather than our reimplementing that logic. That
simplifies the baseURL computation to a single line, and removes the
need for us to be responsible for interpreting the URI RFCs.
String baseURL=new
java.io.File(prevUserDir).toPath().toUri().toString();
report.logStatusMsg("user.dir baseURI is: " + baseURL);
Nitpick: If possible, I'd like to see the executable bit set on the
build.sh files. Yes, the user can set it after checking out, but Git is
able to record this so it's checked out already executable. That may
require pushing the change up from a Unix/Linux system; I'm not sure
whether it can be set from a Windows clone. (Ideally I'd also like to
see them renamed to not have the .sh suffix, but I can see that Windows
users benefit from the hint about what kind of files these are.)
Optional: We *could* check in the Eclipse configuration files
(org.eclipse.jdt.core.prefs and ...uri.prefs) for the -java and -test
projects, so they check out into Eclipse ready to build. But that would
need consensus on what config we want to make our default.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org
For additional commands, e-mail: dev-h...@xalan.apache.org
