Thanks; always learning new git tricks...
--
/_ Joe Kesselman (he/him/his)
-/ _) My Alexa skill for New Music/New Sounds fans:
/ https://www.amazon.com/dp/B09WJ3H657/
() Plaintext Ribbon Campaign
/\ Stamp out HTML mail!
________________________________
From: Stanimir Stamenkov <s7a...@netscape.net.INVALID>
Sent: Monday, March 13, 2023 3:55:12 AM
To: dev@xalan.apache.org <dev@xalan.apache.org>
Subject: Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC9
Sun, 12 Mar 2023 13:39:13 -0400, /Joseph Kessselman/:
> I'd also like to propose that my change for
> SystemIDResolverAPITest.testCase1() be reworked one more time, to use
> the Java library rather than our reimplementing that logic. That
> simplifies the baseURL computation to a single line, and removes the
> need for us to be responsible for interpreting the URI RFCs.
>
> String baseURL=new java.io.File(prevUserDir).toPath().toUri().toString();
This is basically the same (only java.nio.file):
String baseURL =
java.nio.file.Paths.get(prevUserDir).toUri().toString();
> Nitpick: If possible, I'd like to see the executable bit set on the
> build.sh files. Yes, the user can set it after checking out, but Git is
> able to record this so it's checked out already executable. That may
> require pushing the change up from a Unix/Linux system; I'm not sure
> whether it can be set from a Windows clone.
git add --chmod=+x build.sh
works on Windows just fine. Git Bash on Windows doesn't need the .sh
extension (nor the executable bit) to recognize the script as executable
– it seems to look just for a shebang at the start.
--
Stanimir
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org
For additional commands, e-mail: dev-h...@xalan.apache.org
