Unless we're sure the output is OK, I'd rather move whitespace35 to a separate under-investigation file which isn't normally run, instead of deleting it. (Known quibbles?)
I still haven't gotten around to running the test suite against the currently released Xalan. If the same failures existed there -- if there are no _regressions_ -- we can release as it stands. If we can reduce the failures that's better, of course -- /_ Joe Kesselman (he/him/his) -/ _) My Alexa skill for New Music/New Sounds fans: / https://www.amazon.com/dp/B09WJ3H657/ () Plaintext Ribbon Campaign /\ Stamp out HTML mail! ________________________________ From: Elliotte Rusty Harold <elh...@ibiblio.org> Sent: Sunday, March 19, 2023 8:58:59 AM To: dev@xalan.apache.org <dev@xalan.apache.org> Subject: Re: [request to review, and vote] XalanJ 2.7.3 release candidate RC9 Do you have a link to whitespace35? On Sun, Mar 19, 2023 at 11:44 AM Mukul Gandhi <muk...@apache.org> wrote: > > Hi Joseph & all, > > On Sun, Mar 12, 2023 at 11:09 PM Joseph Kessselman <kesh...@alum.mit.edu> > wrote: > > > > I am still seeing ./build.sh conf.xsltc on Linux reporting failure on > > multiple tests (whitespace35, output63, idkey49, idkey31, math111) > > > Technically since conf.xsltc reports > > success we can defend this as a clean release candidate, but I'd be > > happier if we were sure of their status (and had issues open on them). > > The XalanJ conf.xsltc tests (from xalan-test repos's master branch) > whitespace35, output63, idkey49, idkey31, math111 were the only tests > that were failing with XalanJ's XSLTC processor. > > I've fixed the test idkey31 (the changes can be seen within the > xalan-test repos's master branch). > > For the following tests, XalanJ's XSLTC processor has bug (but > XalanJ's interpretive processor is compliant for these tests), > > output63 (the relevant jira issue created is > https://issues.apache.org/jira/browse/XALANJ-2642) > idkey49 (the relevant jira issue created is > https://issues.apache.org/jira/browse/XALANJ-2640) > math111 (the relevant jira issue created is > https://issues.apache.org/jira/browse/XALANJ-2641) > > The test whitespace35 looks to be the only conf.xsltc test that needs > to be addressed as of now. For this test, it's XSLT file mentions > following, > "Test for whitespace stripping from source documents retrieved with > the document() function. The spec is a little vague on this". Since > the test description itself says that, "The spec is a little vague on > this", I'd suggest to delete this test from the xalan-test repo's > master branch. > > With XalanJ test suite (from xalan-test repos's master branch), there > are total 36 whitespace tests available as of now. Therefore deleting > the test whitespace35 should be ok I feel. Any thoughts please? > > > -- > Regards, > Mukul Gandhi > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org > For additional commands, e-mail: dev-h...@xalan.apache.org > -- Elliotte Rusty Harold elh...@ibiblio.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
