Confirmed. I reverted indentation and all smoketests pass.
This needs to be fixed.
I would argue for reverting the change, or at the very least making it
EXTREMELY clear in the README that the current code has altered a
default behavior and explaining how to get the old behavior back (either
by changing the default in output_xml.properties or by setting the
property explicitly in user code). There may be users who, like the test
suite, were depending upon the old behavior.
PLEASE test before making a pull request. Unexpected side effects can
kill you in this business.
(Ideally, we would have Git automation which would automatically run a
full regression test any time a pull request is made and post a comment
saying which results have changed...)
On 6/13/2023 10:00 AM, Joseph Kessselman wrote:
When I run smoketest on a recent clone-and-build under Linux. I'm
getting some instances of
[xalantest] mismatch-value;TEXT()len=1;TEXT()len=3;values do not match
[xalantest] mismatch-value-gold;TEXT();
[xalantest]
[xalantest]
[xalantest] mismatch-value-text;TEXT();
[xalantest]
[xalantest]
[xalantest] XHTFileCheckService files were not equal
which appear at first glance to be because XHTFileCheck is looking for
exact match of text nodes, but the "gold" files are unindented while
the default is now to indent.
Possible fixes:
1) Change the gold files to match the currently expected behavior.
2) Revert the default-indentation change.
3) Change the test framework to assert specific indentation or lack
thereof AND make sure the gold files conform to that behavior. Main
advantage is making the behavior explicit for those who might want to
reuse our test suite (assuming we're still considering that use case.)
I'm seeing a fair number of other new complaints too, which may or may
not be the same issue; I haven't tried reverting the indentation to
check.
[xalantest] FAIL! Extension test of javaSample3.xsl
[xalantest] FAIL! Extension test of javaElem01.xsl
[xalantest] FAIL! ExtensionTestlet{trax} librarySet02.xsl
[xalantest] FAIL! ExtensionTestlet{trax} libraryMath01.xsl
[xalantest] FAIL! ExtensionTestlet{trax} librarySet01.xsl
[xalantest] FAIL! ExtensionTestlet{trax} libraryMath02.xsl
[xalantest] FAIL! StylesheetTestlet{trax} sort-alphabet-polish.xsl
[xalantest] FAIL! StylesheetTestlet{trax} sort-alphabet-russian.xsl
[xalantest] FAIL! StylesheetTestlet{trax} sort-alphabet-english.xsl
[xalantest] FAIL! StylesheetTestlet{trax} namespace23.xsl
[xalantest] FAIL! StylesheetTestlet{trax} namespace140.xsl
[xalantest] FAIL! StylesheetTestlet{trax} namespace02.xsl
[xalantest] FAIL! StylesheetTestlet{trax} predicate38.xsl
[xalantest] FAIL! StylesheetTestlet{trax} variable56.xsl
[xalantest] FAIL! StylesheetTestlet{trax} reluri11.xsl
[xalantest] FAIL! StylesheetTestlet{trax} idkey59.xsl
[xalantest] FAIL! StylesheetTestlet{trax} lre15.xsl
[xalantest] FAIL! StylesheetTestlet{trax} lre18.xsl
[xalantest] FAIL! StylesheetTestlet{trax} mdocs16.xsl
[xalantest] FAIL! StylesheetTestlet{trax} axes130.xsl
[xalantest] FAIL! StylesheetTestlet{trax} axes129.xsl
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
