Hi Joseph, On Tue, Jun 13, 2023 at 7:53 PM Joseph Kessselman <[email protected]> wrote: > > Confirmed. I reverted indentation and all smoketests pass. > > This needs to be fixed. > > I would argue for reverting the change, or at the very least making it > EXTREMELY clear in the README that the current code has altered a > default behavior and explaining how to get the old behavior back (either > by changing the default in output_xml.properties or by setting the > property explicitly in user code). There may be users who, like the test > suite, were depending upon the old behavior.
If you wish, we can revert the XalanJ XSLT serializer's indentation level to its previous status (I guess, that was zero previously and now that's two I believe), on the dev 'master' branch. You may yourself do this if you wish (I guess, you may be having XalanJ commit privileges). I've another suggestion related to this. We, could have XalanJ XSLT serializer's default indentation level as what is currently on the dev repos (which is two)? The XalanJ test suite, could use another instance of XalanJ jar (most likely created locally) that has earlier XSLT serializer indentation level (i.e, zero), so that XalanJ current test suite works as previously. Any future XalanJ binary distribution, should be made available with XSLT serializer default indentation level, as what is currently on the dev repos (i.e, two). Also, I'd request to have the XalanJ XSLT serializer's default indentation level, on the branch xalan-j_xslt3.0 to what is currently there on this branch (i.e, two), since that's helpful during development. -- Regards, Mukul Gandhi --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
